Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the old query builder #2522

Closed
lmsurpre opened this issue Jun 16, 2021 · 1 comment
Closed

Deprecate the old query builder #2522

lmsurpre opened this issue Jun 16, 2021 · 1 comment
Assignees
@lmsurpre
Labels
deprecation
Milestone
Sprint 2021-09

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Jun 16, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
We introduced a new query builder under #2326 along with a config setting to opt into the old one.
Initially, we kept the old query builder in place because we still use that one for whole-system search.
Now that whole-system search is reworked and on the new query builder, its time to mark the old query builder as deprecated.

Describe the solution you'd like

  1. Add class-level deprecation annotations to the old query builder classes.
  2. Ensure those classes are not used from anywhere
  3. Deprecate the FHIRConfiguration constant for fhirServer/search/enableOptQueryBuilder
  4. Note it all in the release notes

Describe alternatives you've considered

Acceptance Criteria

Additional context
Upon completion of this work item, we should open a separate issue for its eventual removal.
@lmsurpre lmsurpre mentioned this issue Jun 17, 2021
Merged
@lmsurpre lmsurpre added this to the Sprint 2021-09 milestone Jul 7, 2021
@lmsurpre lmsurpre self-assigned this Jul 8, 2021
lmsurpre added a commit that referenced this issue Jul 8, 2021
@lmsurpre
issue #2522 - Mark everything related to the old query builder
8e052cf 
deprecated

I also removed the previously deprecated fhir-persistence-proxy module.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Jul 8, 2021
@lmsurpre
issue #2522 - Mark everything related to the old query builder
565b94e 
deprecated

I also removed the previously deprecated fhir-persistence-proxy module.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Jul 8, 2021
@lmsurpre
issue #2522 - Mark everything related to the old query builder
3438781 
deprecated

I also removed the previously deprecated fhir-persistence-proxy module.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Jul 9, 2021
@lmsurpre @michaelwschroeder
issue #2522 - Mark everything related to the old query builder deprec…
a387e1a 
…ated (#2591)

* issue #2522 - Mark everything related to the old query builder
deprecated

I also removed the previously deprecated fhir-persistence-proxy module.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

* Updates per PR review

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

Co-authored-by: Michael W Schroeder <66479070+michaelwschroeder@users.noreply.github.com>
@lmsurpre
Copy link
Member Author

Deprecation labels are added.

@lmsurpre lmsurpre mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
deprecation
Projects
None yet
Milestone
Sprint 2021-09
Development

No branches or pull requests
1 participant
@lmsurpre