-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token search for |<code>
should only match codes with no systems
#2550
Comments
lmsurpre
added a commit
that referenced
this issue
Jun 24, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 24, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 24, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 24, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 24, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 25, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 25, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 25, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Jun 25, 2021
When we store a token value without a system, we end up using a special placeholder system instead of saving NULL. With this PR, we will now use that system when we search for system-less codes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
tbieste
added a commit
that referenced
this issue
Jun 30, 2021
issue #2550 - add default system for `|<code>` searches
I verified this fix in my local development environment running the latest code from main. I ran the following searches:
I also inspected the generated SQL for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently our SearchUtil.parseQueryParameterValuesString has logic like this:
That means its handling
|<code>
just like<code>
. This is less efficient (see the performance guide) and also not quite rightDescribe the solution you'd like
In our JDBC persistence layer we have an optimization whereby we store code with no system with a placeholder system.
The REST layer needs to somehow pass a placeholder like this to the Persistence layer so that we can distinguish between a search for no system vs a search for any system.
This can be the same placeholder or it could be a different one thats part of the contract. Either way, it should probably go into the javadocs somewhere.
Describe alternatives you've considered
Acceptance Criteria
WHEN we get a search like
param=|<code>
THEN it does NOT retrieve this resource
Additional context
The text was updated successfully, but these errors were encountered: