Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a fhir-bucket docker image #2570

Closed
prb112 opened this issue Jul 6, 2021 · 7 comments
Closed

Create a fhir-bucket docker image #2570

prb112 opened this issue Jul 6, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request P2 Priority 2 - Should Have showcase Used to Identify End-of-Sprint Demos

Comments

@prb112
Copy link
Contributor

prb112 commented Jul 6, 2021

Is your feature request related to a problem? Please describe.
Include the fhir-bucket in the docker image

Describe the solution you'd like
Wrap fhir-bucket in its own docker image (similar to the schema tool).

The new image should be peer to ibm-fhir-server on DockerHub.

The user experience of the image should be focused on making reindex as simple as possible, however it should not preclude the usage of loading.

Describe alternatives you've considered
Include it in our ibm-fhir-server image directly.

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Add any other context or screenshots about the feature request here.

@lmsurpre
Copy link
Member

lmsurpre commented Jul 6, 2021

I added an alternative option under the "Describe alternatives" section which is to give fhir-bucket its own image.

@prb112 prb112 added the enhancement New feature or request label Jul 7, 2021
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Sep 20, 2021
@lmsurpre lmsurpre changed the title Include the fhir-bucket in the docker image Create a fhir-bucket docker image Sep 20, 2021
@prb112
Copy link
Contributor Author

prb112 commented Sep 22, 2021

requested the repository on DockerHub

@prb112 prb112 self-assigned this Sep 22, 2021
@prb112 prb112 added this to the Sprint 2021-13 milestone Sep 22, 2021
@prb112
Copy link
Contributor Author

prb112 commented Sep 22, 2021

agreed on ibm-fhir-bucket-tool

@lmsurpre
Copy link
Member

opened #2913 with a suggested edit

@lmsurpre
Copy link
Member

lmsurpre commented Oct 28, 2021

I tested the new image by wrapping it in a helm chart with a single kubernetes job:

apiVersion: batch/v1
kind: Job
metadata:
  name: {{ .Release.Name }}
  labels:
    chart: {{ .Chart.Name }}-{{ .Chart.Version }}
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
spec:
  template:
    metadata:
      labels:
        app: {{ template "name" . }}
        release: {{ .Release.Name }}
    spec:
      restartPolicy: Never
      imagePullSecrets:
        - name: {{ .Values.image.pullSecret }}
      volumes:
        - name: fhir-properties
          secret:
            secretName: {{ .Release.Name }}-secret
        - name: fhir-client-truststore
          secret:
            secretName: fhir-client-truststore
      containers:
        - name: {{ template "name" . }}
          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
          imagePullPolicy: {{ .Values.image.pullPolicy }}
          volumeMounts:
            - name: fhir-properties
              mountPath: /fhir.properties
              subPath: fhir.properties
            - name: fhir-client-truststore
              mountPath: /fhirClientTrustStore.p12
              subPath: fhirClientTrustStore.p12
          args: [
            "--no-scan",
            "--fhir-properties", "/fhir.properties",
            "--tenant-name", "{{ .Values.tenant.id }}",
            "--reindex-tstamp", "{{ .Values.reindex.tstamp }}",
            "--reindex-resource-count", "50",
            "--reindex-concurrent-requests", "{{ .Values.reindex.maxConcurrentRequests }}",
            "--reindex-client-side-driven",
            "--reindex-start-with-index-id", "{{ .Values.reindex.startId }}"
          ]
  backoffLimit: 4

Because the image is so thin, its necessary to mount fhir properties and a truststore in order to invoke reindex.
We should consider either documenting this or providing a helm chart to make this easier...maybe we just extend https://artifacthub.io/packages/helm/alvearie/ibm-fhir-server with a flag for doing reindex?

@prb112 prb112 modified the milestones: Sprint 2021-14, Sprint 2021-15 Nov 12, 2021
@prb112
Copy link
Contributor Author

prb112 commented Nov 15, 2021

Updated https://hub.docker.com/r/ibmcom/ibm-fhir-bucket-tool - let me know if you want more.

@prb112
Copy link
Contributor Author

prb112 commented Nov 15, 2021

Chat on the Side agreed it is a good start, will update going forward

@prb112 prb112 closed this as completed Nov 15, 2021
@lmsurpre lmsurpre added the showcase Used to Identify End-of-Sprint Demos label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority 2 - Should Have showcase Used to Identify End-of-Sprint Demos
Projects
None yet
Development

No branches or pull requests

2 participants