Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$import allows adding Resources of multiple types in the same ndjson which could include unsupported resources. #3180

Closed
prb112 opened this issue Jan 12, 2022 · 1 comment
Closed

$import allows adding Resources of multiple types in the same ndjson which could include unsupported resources. #3180

prb112 opened this issue Jan 12, 2022 · 1 comment
Assignees
@prb112
Labels
bug Something isn't working bulk-data connectathon Work derived from connectathons P2 Priority 2 - Should Have

Comments

@prb112
Copy link
Contributor

prb112 commented Jan 12, 2022

Describe the bug
A clear and concise description of what the bug is.
$import allows adding Resources of multiple types in the same ndjson which could include unsupported resources.

Environment
Which version of IBM FHIR Server? 4.10.2

To Reproduce
Steps to reproduce the behavior:

  1. Create an NDJSON with a Condition resource
  2. Create a fhir-server-config.json which doesn't have Condition
  3. Condition should not be loaded but is....

Expected behavior
A clear and concise description of what you expected to happen.

I expect a filtering of the unsupported resources.

Additional context
Add any other context about the problem here.
@prb112 prb112 added bug Something isn't working bulk-data connectathon Work derived from connectathons labels Jan 12, 2022
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Jan 26, 2022
@prb112 prb112 self-assigned this Feb 14, 2022
prb112 added a commit that referenced this issue Feb 16, 2022
@prb112
allows adding Resources of multiple types in the same ndjson which c…
5560089 
…ould include unsupported resources. #3180

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 17, 2022
@prb112 @lmsurpre
#3180 - $import allows adding Resources of multiple types in the same…
908b277 
… ndjson which could include unsupported resources. (#3351)

* allows adding Resources of multiple types in the same ndjson which could include unsupported resources. #3180

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Update to include the OperationOutcome

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Update Test

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Add logging

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Update to use a strong equals comparator

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Update fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/jbatch/load/ChunkWriter.java

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>

Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
@d0roppe
Copy link
Collaborator

d0roppe commented Feb 21, 2022

Verified that $import did not import the resource if it was not known.

@d0roppe d0roppe closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working bulk-data connectathon Work derived from connectathons P2 Priority 2 - Should Have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @d0roppe