Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US Core contains invalid fhirpath expressions #3490

Closed
lmsurpre opened this issue Mar 21, 2022 · 1 comment
Closed

US Core contains invalid fhirpath expressions #3490

lmsurpre opened this issue Mar 21, 2022 · 1 comment
Assignees
@lmsurpre
Labels
enhancement New feature or request

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Mar 21, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
2 of the fhirpath expressions in us core 4.0 have issues with repeating elements:

Describe the solution you'd like
We should patch the fhirpath expressions so that they work properly

Describe alternatives you've considered

Acceptance Criteria

  1. GIVEN a server configured with our us-core jar
    AND a Condition resource with multiple category elements
    AND it claims conformance to http://hl7.org/fhir/us/core/StructureDefinition/us-core-condition
    WHEN create or $validate is called with that resource
    THEN it either succeeds or fails with a client error (no server error)

  2. GIVEN a server configured with our us-core jar
    AND a Provenance resource with multiple agent elements (and at least one with agent.onBehalfOf)
    AND it claims conformance to http://hl7.org/fhir/us/core/StructureDefinition/us-core-provenance
    WHEN create or $validate is called with that resource
    THEN it either succeeds or fails with a client error (no server error)

Additional context
@lmsurpre lmsurpre added the enhancement New feature or request label Mar 21, 2022
@lmsurpre lmsurpre self-assigned this Mar 21, 2022
@lmsurpre lmsurpre mentioned this issue Mar 21, 2022
Closed
lmsurpre added a commit that referenced this issue Mar 21, 2022
@lmsurpre
issue #3490 - patch us core 4.0 fhirpath expressions
1b0c62b 
Add tests under com.ibm.fhir.ig.us.core.test.v400.ConformanceTest to
show the issues.

For Provenance: fix provenance-1 to handle multiple agents

For Condition: fix us-core-1 to handle multiple categories


Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 21, 2022
@lmsurpre
issue #3490 - patch us core 4.0 fhirpath expressions
93ab608 
Add tests under com.ibm.fhir.ig.us.core.test.v400.ConformanceTest to
show the issues.

For Provenance: fix provenance-1 to handle multiple agents

For Condition: fix us-core-1 to handle multiple categories


Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 21, 2022
@lmsurpre
Merge pull request #3492 from IBM/issue-3490
6a59456 
issue #3490 - patch us core 4.0 fhirpath expressions
@d0roppe
Copy link
Collaborator

d0roppe commented Mar 31, 2022

verified that with both Condition and Provenance work according to the acceptance criteria. Closing issue

@d0roppe d0roppe closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @d0roppe