Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update version of java sdk-core #47

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

MDarmawan
Copy link
Collaborator

@MDarmawan MDarmawan commented Nov 20, 2024

Title: Update IBM Cloud sdk-core version to fix CVEs

Short Description: Addresses #46

Checklist

  • I have performed a self-review of my changes
  • My code/changes are commented (especially hard-to-understand areas)
  • I have written/updated new unit tests for the core changes or new/updated tests are not necessary
  • I have posted test results from local tests or made sure the TravisCI tests succeeded
  • I have made changes to the examples in examples/kp-sdk-example where relevant, and tested those changes
    - run mvn clean install to build the sdk, then run mvn clean install in the examples/kp-sdk-example directory to build the examples.
    - To run the example jar's examples, use java -jar kp-sdk-example-1.0-SNAPSHOT.jar $EXAMPLE_NAME

Changes

Briefly identify changes made in this PR

Test Results

Test results may be run by the TravisCI build. If so, please verify whether they are running properly.

Dependencies

Is anything changing with respect to dependencies (the pom.xml or gradle file)? Explain that here and why they were changed.

Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@markyak
Copy link

markyak commented Nov 21, 2024

What's the ETA for this? Let me know if you would like me to review the PR.

@markyak
Copy link

markyak commented Nov 21, 2024

Can you please also update okhttp3 to 4.12.0?
https://mvnrepository.com/artifact/com.squareup.okhttp3/okhttp/4.12.0

4.10.0 has a vulnerability - https://mvnrepository.com/artifact/com.squareup.okhttp3/okhttp/4.10.0

Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@stephaniegalang stephaniegalang merged commit 7b4a874 into master Nov 21, 2024
3 checks passed
@stephaniegalang stephaniegalang deleted the cve-nov-2024 branch November 21, 2024 22:49
stephaniegalang pushed a commit that referenced this pull request Nov 22, 2024
## [1.0.1](1.0.0...1.0.1) (2024-11-22)

### Bug Fixes

* **build:** bump my version ([#49](#49)) ([a2a661d](a2a661d))
* **build:** Bump testng from 7.4.0 to 7.5.1 ([#38](#38)) ([b58b040](b58b040))
* **build:** Update Travis CI file ([#48](#48)) ([ab23abc](ab23abc))
* **build:** update version of java sdk-core ([#47](#47)) ([7b4a874](7b4a874))
@stephaniegalang
Copy link
Collaborator

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants