From f2be943024e985054d028c49ae9cceb23c7b58e3 Mon Sep 17 00:00:00 2001 From: Norbert Biczo Date: Mon, 3 Jun 2024 15:04:56 +0200 Subject: [PATCH] fix: specify the maximum version of `requests` to avoid regression Version `2.23.3` of the `requests` package broke our custom `SSLHTTPAdapter`. This commit defines the maximum version of that package, to make sure it will continue working without an issue. Note that, this is a short term solution only. For more details see this issue: https://github.com/psf/requests/issues/6730 Signed-off-by: Norbert Biczo --- ibm_cloud_sdk_core/utils.py | 2 ++ requirements.txt | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ibm_cloud_sdk_core/utils.py b/ibm_cloud_sdk_core/utils.py index 711720ea..d696a941 100644 --- a/ibm_cloud_sdk_core/utils.py +++ b/ibm_cloud_sdk_core/utils.py @@ -31,6 +31,8 @@ import dateutil.parser as date_parser +# pylint: disable=fixme +# TODO: revert the change in the `requirement.txt` once this class become deprecated! class SSLHTTPAdapter(HTTPAdapter): """Wraps the original HTTP adapter and adds additional SSL context.""" diff --git a/requirements.txt b/requirements.txt index 0fd6e2a2..2dba176c 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,4 +1,4 @@ -requests>=2.31.0,<3.0.0 +requests>=2.31.0,<2.32.3 urllib3>=2.1.0,<3.0.0 python_dateutil>=2.8.2,<3.0.0 PyJWT>=2.8.0,<3.0.0