Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming ErrXxx constants is an API changing change #1261

Closed
nsd20463 opened this issue Jan 23, 2019 · 5 comments
Closed

renaming ErrXxx constants is an API changing change #1261

nsd20463 opened this issue Jan 23, 2019 · 5 comments

Comments

@nsd20463
Copy link
Contributor

FYI commit 04e4286 breaks [my] code because it removes several public ErrXxx names.

Perhaps this is deliberate, though strange in a tagged "1.something" repo. Or it's an accident and you meant to keep the old names around too.
@bai
Copy link
Contributor

bai commented Jan 23, 2019

cc: @nrvnrvn @varun06

@bai
Copy link
Contributor

bai commented Jan 23, 2019

Yep, this is a valid degradation.

@varun06
Copy link
Contributor

varun06 commented Jan 23, 2019

ouch, can we please create a release and mention the breaking api change part. Will be more careful in future for these changes.

@bai
Copy link
Contributor

bai commented Jan 23, 2019

I'm revering the PR in #1262 on 🍏. Sorry for the trouble and thanks for reporting!

@nsd20463
Copy link
Contributor Author

Thanks.

@ae-govau ae-govau mentioned this issue Sep 8, 2023
Merged
@ae-govau ae-govau mentioned this issue Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bai @varun06 @nsd20463