From b3891edceaff0a26c4d20467da4d1dc905319b4b Mon Sep 17 00:00:00 2001 From: wica_sofico Date: Fri, 27 Nov 2020 16:14:36 +0100 Subject: [PATCH 1/2] Do not ignore Consumer.Offsets.AutoCommit.Enable config on Close --- offset_manager.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/offset_manager.go b/offset_manager.go index b4fea8226..4f480a08b 100644 --- a/offset_manager.go +++ b/offset_manager.go @@ -113,10 +113,12 @@ func (om *offsetManager) Close() error { om.asyncClosePOMs() // flush one last time - for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ { - om.flushToBroker() - if om.releasePOMs(false) == 0 { - break + if om.conf.Consumer.Offsets.AutoCommit.Enable { + for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ { + om.flushToBroker() + if om.releasePOMs(false) == 0 { + break + } } } From 2b925afc59b39f696eb76a9747086abde379c502 Mon Sep 17 00:00:00 2001 From: wica_sofico Date: Tue, 12 Jan 2021 13:48:01 +0100 Subject: [PATCH 2/2] trigger GitHub actions