Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit developer dependencies and prune down requirements-dev.txt #1532

Closed
lbianchi-lbl opened this issue Nov 12, 2024 · 0 comments · Fixed by #1533
Closed

Revisit developer dependencies and prune down requirements-dev.txt #1532

lbianchi-lbl opened this issue Nov 12, 2024 · 0 comments · Fixed by #1533
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@lbianchi-lbl
Copy link
Contributor

  • Even though we're still working on reproducing the issue, Issues with developer installation with "Failed to build jupyter_contrib_nbextensions" error #1529 seems to be caused by jupyter_contrib_nbextensions erroring out during installation, preventing the rest of the packages (including idaes-pse itself) from being installed
  • jupyter_contrib_nbextensions is part of the developer dependencies in requirements-dev.txt, but it's not clear (1) why it was originally added, and (2) whether we still need it
  • From a quick look, the same can be said of other dependencies in requirements-dev.txt

Because of this, I think we should look through requirements-dev.txt and get rid of all the dependencies we're not using.

@lbianchi-lbl lbianchi-lbl added the dependencies Pull requests that update a dependency file label Nov 12, 2024
@lbianchi-lbl lbianchi-lbl self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant