Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements needed on the Define Climatic Dialog #9272

Open
rdstern opened this issue Nov 24, 2024 · 3 comments · May be fixed by #9275
Open

Minor improvements needed on the Define Climatic Dialog #9272

rdstern opened this issue Nov 24, 2024 · 3 comments · May be fixed by #9275
Labels
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Nov 24, 2024

Heris a snapshot of the data, together with the define dialog:

image

There are 3 issues that arose with the data from the recent Bangladesh workshop.

a) Note the names for the Max and Min temperatures and wind speed were not recognised. Do not fix that. The problem is different. Please check the tab orders generally. After entering Min into Minimum Temperatures the next field should be Maximum, but it isn't.
b) When I return to the dialog (after defining the data as climatic) it seems to "remember. But other times - perhaps after closing and the re-opening the data book, it doesn't - as shown above. Could you check the code, so when the data are defined as climatic, they are always filled in, on the dialog.
I hope these can be done quickly, so we can merge.
c) I am less sure here, but these data included dry bulb, which is one of many possible additional elements. I am happy with the ones on the list, but would also like a facility to define more - and there are so many! I suggest we omit Cloud Cover (to make space) and add a More button. If checked it opens a simple sub-dialog with the data selector and a multiple receiver. It has the label More Elements: They are just entered here. Then press Return. They are then called more1, more2, etc in the climatic type.

@rdstern rdstern added this to the 0.7.x milestone Nov 24, 2024
@N-thony
Copy link
Collaborator

N-thony commented Nov 25, 2024

@rdstern I tried with the dodoma dataset and it seems to work fine, can you share the data you have used?

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 25, 2024

@N-thony that's the point - it does. Now I have a thought. With Dodoma change Tmax to just Max and Tmin to just Min. Then try define again. I need names for max and min that we don't recognise. Even use xxx yyy and zzz for temperature and sunshine names perhaps.

Then define as climatic, then save as test Then close. When you open again it has forgotten the names defined earlier I think? And the tab order when you enter Tmax (or Tmin - the first one anyway - is wrong!

@N-thony
Copy link
Collaborator

N-thony commented Nov 25, 2024

@N-thony that's the point - it does. Now I have a thought. With Dodoma change Tmax to just Max and Tmin to just Min. Then try define again. I need names for max and min that we don't recognise. Even use xxx yyy and zzz for temperature and sunshine names perhaps.

Then define as climatic, then save as test Then close. When you open again it has forgotten the names defined earlier I think? And the tab order when you enter Tmax (or Tmin - the first one anyway - is wrong!

@rdstern, yes this wouldn't work, below are the names we recognized for maximum and minimum temperatures.
We can consider min and max too.
image

@N-thony N-thony linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants