-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Column Renaming for Selected Columns #9282
base: master
Are you sure you want to change the base?
Improve Column Renaming for Selected Columns #9282
Conversation
@N-thony I can't see what has changed here. Can you add more details. |
@rdstern, do column selection first and try to rename column from the current column selection with any option from the Rename dialogue |
@rdstern have you re-tested this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-thony I think your change may be working. But there are various problems, either from the changes, or perhaps always there?
a) whenever I click on rename I get the developer error.
b) When I did the select shown below I only got 2 columns visible out of the 3. I got the first column to be visible, by scrolling left, so no big deal. But whern I now do a new select, only the 2 columns appear. Of course I'd like them all, not just those in the current select, because I'm doing a new select. Maybe when new select is chosen there should be an unselect first?
Fixes partially #9265
@rdstern this PR tempts to fix the issue when renaming selected columns. It completes issue #9265. Have a look