865 hi l1b spin phase #1102
Merged
865 hi l1b spin phase #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rable spin start time Add Hi L1B function for populating spin phase Add test coverage for Hi L1B compute_instrument_spin_phase function Update test using fake spin data fixture
tech3371
approved these changes
Nov 1, 2024
| """Test coverage for compute_instrument_spin_phase.""" | ||
| # set the get_instrument_spin_phase mock to return an array of values between | ||
| # 0 and 1 | ||
| parse_sensor_number_mock.side_effect = lambda x, y: np.linspace(0, 1, len(x)) |
There was a problem hiding this comment.
Learn something new about .side_effect!
But this questions is a curiosity question. How is x, y used here? I thought parse_sensor_number() takes in only one argument. I see that you use this returned value to compare at line 185.
There was a problem hiding this comment.
Haha, I have my mock names mixed up. The argument order from decorators is reversed from the decorator order. This is actually setting the side_effect for the thing mocking get_instrument_spin_phase which is what I intended. And that function takes two arguments. I'll fix that.
subagonsouth
merged commit 8ac406c
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Updated Files
_set_spin_data_filepathtouse_fake_spin_data_for_timeand modified to allow configurable start and end time.generate_spin_datato accept and correctly use floating point MET times as inputuse_test_spin_data_csvfixture so that a test spin phase file can be used if neededevent_mettimes.Closes: #865