Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hi L1b test marked xfail #681

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix Hi L1b test marked xfail #681

merged 1 commit into from
Jul 2, 2024

Conversation

subagonsouth
Copy link
Contributor

@subagonsouth subagonsouth commented Jul 2, 2024 •
edited
Loading

Change Summary

Remove xfail on test that isn't failing

Overview

The test wasn't failing. I just removed the @pytest.mark.xfail decorator.

Updated Files

  • imap_processing/tests/hi/test_hi_l1b.py
    • remove xfail decorator from test that passes

Closes #672

@subagonsouth subagonsouth added the Ins: Hi Related to the IMAP-Hi instrument label Jul 2, 2024
@subagonsouth subagonsouth requested a review from a team July 2, 2024 16:49
@subagonsouth subagonsouth self-assigned this Jul 2, 2024
maxinelasp
maxinelasp approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy review 😆

@subagonsouth subagonsouth merged commit 706c53d into IMAP-Science-Operations-Center:dev Jul 2, 2024
17 checks passed
@subagonsouth subagonsouth deleted the 672-bug-fix-test-imap_processingtestshitest_hi_l1bpytest_hi_l1b_de branch July 2, 2024 17:23
@greglucas greglucas mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxinelasp maxinelasp maxinelasp approved these changes

Assignees

@subagonsouth subagonsouth

Labels
Ins: Hi Related to the IMAP-Hi instrument
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG - Fix test imap_processing/tests/hi/test_hi_l1b.py::test_hi_l1b_de
2 participants
@subagonsouth @maxinelasp