From c53c38d10e2aa45f9e468f6f43470d554683e415 Mon Sep 17 00:00:00 2001 From: Rohitesh Date: Mon, 14 Jun 2021 14:53:10 +0530 Subject: [PATCH 1/4] improve tests for abstractTemplate --- .../spoon/test/template/TemplateTest.java | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/test/java/spoon/test/template/TemplateTest.java b/src/test/java/spoon/test/template/TemplateTest.java index d4dcfacd2df..a153ba4b1a8 100644 --- a/src/test/java/spoon/test/template/TemplateTest.java +++ b/src/test/java/spoon/test/template/TemplateTest.java @@ -44,10 +44,7 @@ import spoon.support.compiler.FileSystemFile; import spoon.support.compiler.FileSystemFolder; import spoon.support.template.Parameters; -import spoon.template.ExpressionTemplate; -import spoon.template.Substitution; -import spoon.template.TemplateMatcher; -import spoon.template.TemplateParameter; +import spoon.template.*; import spoon.test.template.testclasses.AnExpressionTemplate; import spoon.test.template.testclasses.AnotherFieldAccessTemplate; import spoon.test.template.testclasses.ArrayAccessTemplate; @@ -442,6 +439,25 @@ public void testCheckBoundTemplate() throws Exception { assertEquals(injectedCode, method.getBody().getStatement(0)); } + @Test + public void testAbstractTemplateIsWellFormed() { + // contract: IsWellFormed method of AbstractTemplate class returns false if there are zero template parameter + + // arrange + AbstractTemplate abstractTemplate = new AbstractTemplate() { + @Override + public CtElement apply(CtType targetType) { + return null; + } + }; + + // act + boolean zeroTemplateParameters = abstractTemplate.isWellFormed(); + + // assert + assertFalse(zeroTemplateParameters); + } + @Test public void testTemplateMatcher() throws Exception { // contract: the given templates should match the expected elements From a6e80753912cc679d3476d23f0d1e559fe45ff0a Mon Sep 17 00:00:00 2001 From: Rohitesh Kumar Jain Date: Tue, 15 Jun 2021 13:35:08 +0530 Subject: [PATCH 2/4] Update src/test/java/spoon/test/template/TemplateTest.java MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Simon Larsén --- src/test/java/spoon/test/template/TemplateTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/spoon/test/template/TemplateTest.java b/src/test/java/spoon/test/template/TemplateTest.java index a153ba4b1a8..eec4a5d7a74 100644 --- a/src/test/java/spoon/test/template/TemplateTest.java +++ b/src/test/java/spoon/test/template/TemplateTest.java @@ -444,9 +444,9 @@ public void testAbstractTemplateIsWellFormed() { // contract: IsWellFormed method of AbstractTemplate class returns false if there are zero template parameter // arrange - AbstractTemplate abstractTemplate = new AbstractTemplate() { + AbstractTemplate abstractTemplate = new AbstractTemplate() { @Override - public CtElement apply(CtType targetType) { + public CtElement apply(CtType targetType) { return null; } }; From 2f788bb63a1063ee7087ad1d24eaeb5de5e182df Mon Sep 17 00:00:00 2001 From: Rohitesh Kumar Jain Date: Tue, 15 Jun 2021 13:35:47 +0530 Subject: [PATCH 3/4] Update src/test/java/spoon/test/template/TemplateTest.java MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Simon Larsén --- src/test/java/spoon/test/template/TemplateTest.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/test/java/spoon/test/template/TemplateTest.java b/src/test/java/spoon/test/template/TemplateTest.java index eec4a5d7a74..1dd73891638 100644 --- a/src/test/java/spoon/test/template/TemplateTest.java +++ b/src/test/java/spoon/test/template/TemplateTest.java @@ -451,11 +451,7 @@ public CtElement apply(CtType targetType) { } }; - // act - boolean zeroTemplateParameters = abstractTemplate.isWellFormed(); - - // assert - assertFalse(zeroTemplateParameters); + assertFalse(abstractTemplate.isWellFormed()); } @Test From 952199850db79b534869259aaceb838335e9b028 Mon Sep 17 00:00:00 2001 From: Rohitesh Date: Tue, 15 Jun 2021 15:13:47 +0530 Subject: [PATCH 4/4] rename variable --- src/test/java/spoon/test/template/TemplateTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/spoon/test/template/TemplateTest.java b/src/test/java/spoon/test/template/TemplateTest.java index 1dd73891638..79e7bbcdacd 100644 --- a/src/test/java/spoon/test/template/TemplateTest.java +++ b/src/test/java/spoon/test/template/TemplateTest.java @@ -443,15 +443,14 @@ public void testCheckBoundTemplate() throws Exception { public void testAbstractTemplateIsWellFormed() { // contract: IsWellFormed method of AbstractTemplate class returns false if there are zero template parameter - // arrange - AbstractTemplate abstractTemplate = new AbstractTemplate() { + AbstractTemplate zeroParameterTemplate = new AbstractTemplate() { @Override public CtElement apply(CtType targetType) { return null; } }; - assertFalse(abstractTemplate.isWellFormed()); + assertFalse(zeroParameterTemplate.isWellFormed()); } @Test