Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GE - Multiplicity for geophObjectSet and geophObjectMember associations is not defined #14

Closed
fabiovin opened this issue Oct 6, 2021 · 3 comments · Fixed by #118
Closed
Labels
endorsed The change proposal is endorsed by the MIG. impact on UML The change proposal has an impact on the UML diagram. impact on validator The change proposal has an impact on the INSPIRE validator.
Milestone

Comments

@fabiovin
Copy link
Contributor

fabiovin commented Oct 6, 2021

Change proposal description

The multiplicity of geophObjectSet and geophObjectMember associations of the GeologicCollection feature type is not defined in the UML and in the TG. In the related XSD the multiplicity is 0..* for both associations.

Addressed TG

D2.8.II.4 INSPIRE Data Specification on Geology – Technical Guidelines

Location

Section "5.3.2.1.4. GeologicCollection"

Issue faced

There is an inconsistency between documentation (TG and UML) and the XSD application schema.

Proposed solution

It seems the multiplicity 0..* is the more suitable one since the two associations of the GeologicCollection feature type are related to the feature types defined in another GE application schema. The proposed solution is to specify the multiplicity 0..* in both TG and UML.

Pull request

Not available

Additional information

Kind of issue

editorial

Impact on IR

No

Impact on INSPIRE validator

Yes, at the moment the multiplicity in the ETS is 1 for both associations (https://github.com/inspire-eu-validation/data-ge/blob/master/ge-ia/features.md#geophObjectSet).

Linked issue

INSPIRE-MIF/helpdesk-validator#625

Impact on INSPIRE XML schemas

No, the multiplicity in the schema is already 0..*.

Impact on INSPIRE code lists

No

Change proposer

JRC

@heidivanparys heidivanparys added the impact on validator The change proposal has an impact on the INSPIRE validator. label Oct 29, 2021
@heidivanparys
Copy link
Collaborator

heidivanparys commented Oct 29, 2021

Screenshot of the TG:

image

The relevant diagram in the INSPIRE Consolidated UML model: https://inspire.ec.europa.eu/data-model/approved/r4618-ir/html/index.htm?goto=2:2:2:1:7719

@heidivanparys
Copy link
Collaborator

Meeting 15-12-2021: Change proposal ok.

@heidivanparys heidivanparys added the for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. label Dec 15, 2021
fabiovin added a commit to inspire-eu-validation/data-ge that referenced this issue Jan 14, 2022
Change of the multiplicity of geophObjectSet and geophObjectMember associations according to this TG change proposal: INSPIRE-MIF/technical-guidelines#14.
The related issue on helpdesk-validator is: INSPIRE-MIF/helpdesk-validator#625
@fabiovinci fabiovinci added the impact on UML The change proposal has an impact on the UML diagram. label Feb 23, 2022
@sMorrone
Copy link
Collaborator

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Apr 4, 2022
@fabiovinci fabiovinci added this to the 2023.2 milestone Jun 12, 2023
fabiovinci added a commit to INSPIRE-MIF/uml-models that referenced this issue Jul 20, 2023
Add multiplicity for geophObjectSet and geophObjectMember associations in the mapping table, according to the TG change proposal [#14](INSPIRE-MIF/technical-guidelines#14).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG. impact on UML The change proposal has an impact on the UML diagram. impact on validator The change proposal has an impact on the INSPIRE validator.
Projects
None yet
4 participants