Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY - Manmadeobject keyword change #46

Closed
Shalucik opened this issue May 5, 2022 · 2 comments · Fixed by #96
Closed

HY - Manmadeobject keyword change #46

Shalucik opened this issue May 5, 2022 · 2 comments · Fixed by #96
Labels
endorsed The change proposal is endorsed by the MIG.
Milestone

Comments

@Shalucik
Copy link

Shalucik commented May 5, 2022

Change proposal description

According to the Hydrography Technical Guidelines, section 11.1 Layers to be provided by INSPIRE view services, one of the keywords for the layer "HY.PhysicalWaters.ManMadeObject" is supposed to be "Dick".

We believe this should be "Dyke" as per the Inspire Gemet Keywords list: https://www.eionet.europa.eu/gemet/en/concept/2393

Addressed TG

https://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_HY_v3.1.pdf

Location

https://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_HY_v3.1.pdf
The table in: section 11.1 Layers to be provided by INSPIRE view services
Specifically the Keywords for the layer HY.PhysicalWaters.ManMadeObject

Issue faced

Dick has a very different meaning than Dyke and this looks wrong on our view services.
As such we have already changed our services to use Dyke instead of Dick and we have seen that other countries have done the same.
At the moment the validator doesn't check keywords for view services, but in the future if the validator is going to validate these keywords and the validator follows the technical guidance rules our services would fail.

Proposed solution

Update the table to change "Dick" to "Dyke"

Pull request

Not available as the TG is not yet available in the repository.

@Shalucik Shalucik changed the title TG short name (data theme in case of data specification) - main problem addressed HY - Manmadeobject keyword change May 5, 2022
@sMorrone sMorrone added the for Sub-group The change proposal is to be assessed by the Sub-group label May 6, 2022
@sMorrone
Copy link
Collaborator

Subgroup meeting on 13.09.2022:
subgroup approves.

@sMorrone sMorrone added for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. and removed for Sub-group The change proposal is to be assessed by the Sub-group labels Sep 15, 2022
@fabiovinci
Copy link
Collaborator

During the joint MIG/MIG-T meeting held on 24-25/11/2022, the proposal was endorsed.
More details in the meeting minutes on the 72nd MIG-T meeting page.

@fabiovinci fabiovinci added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Dec 7, 2022
@fabiovinci fabiovinci added this to the 2023.1 milestone Dec 7, 2022
@fabiovinci fabiovinci linked a pull request Jan 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants