Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guestbook: Guestbook csv download has issues if contents also includes commas, title, text q. #3449

Closed
kcondon opened this issue Nov 2, 2016 · 7 comments
Labels
Feature: Guestbook Feature: Metrics + Reports Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Nov 2, 2016

Found by a user, see RT 243224, if a dataset's title contains a comma, loading the guestbook download csv into a spreadsheet requires manually removing the comma before it is properly imported. This would also happen if a question had commas or an answer had commas.

One solution might be to scrub commas from content when writing this doc.


Update by @pdurbin 2018-05-21

connects to #4671

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Type: Bug a defect Feature: Metrics + Reports labels Nov 2, 2016
@pdurbin pdurbin added the User Role: Depositor Creates datasets, uploads data, etc. label Jul 12, 2017
@mheppler
Copy link
Contributor

Closed this issue as a duplicate of Dataverse Guestbook: Custom question output has inconsistent order #4671 and copied over the original comment.

@pdurbin
Copy link
Member

pdurbin commented May 21, 2018

Now that pull request @4700 is in and has nothing to do with commas, @mheppler and I feel a little weird about having this issue closed so I'm re-opening it to put it through QA.

Basically, I added commas all over the place, in questions, answers, dataset titles, etc, and I could not reproduce the bug reported in #4671. It looks like the comma handling was rewritten in Dataverse 4.8 as part of pull request #4057 so I think this bug was fixed then but never tested.

I will say that the code replaces commas with spaces, which is a little weird.

@mheppler
Copy link
Contributor

Confirmed on demo (4.8.6) that commas in answers to custom questions are being replaced with spaces.

screen shot 2018-05-21 at 3 31 08 pm

Also went back and tried commas in the dataset title, as well as custom guestbook questions, and everything seems kosher here. Looks like commas are properly "scrubbed" and the CSV of responses is downloadable and openable.

screen shot 2018-05-21 at 3 37 18 pm

@mheppler
Copy link
Contributor

This looks like the commit 4eb80d1 from @landreev that removed the commas from the responses.

@mheppler
Copy link
Contributor

mheppler commented Mar 6, 2019

This looks like a duplicate of Guestbook: Cannot download a particular guestbook using Chrome, throws duplicate header error #3581 and also Cannot download guestbook in Chrome if Dataverse has a "," in the name #4512.

@kcondon and @scolapasta are the of those. I already suggested to Kevin that #3581 be closed as a duplicate. I will let the two of them arm wrestle it out to determine if this gets closed, or remains open as the one issue to rule them all.

@kcondon
Copy link
Contributor Author

kcondon commented Mar 7, 2019

@mheppler @scolapasta This appears related to the other 2 since it is a problem with Chrome guestbook download when content contains ',' but I'd just point out that this refers to a comma in dataset whereas the other 2 are likely due to comma in dataverse name.

If Gustavo or Dev wants to work on this together (ask Danny) feel free to combine them. I'd combine to this one, just point to the other 2 since this is the earliest one.

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Guestbook Feature: Metrics + Reports Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants