Changed file opens to binary mode for to_csv calls. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialized in isatab2json conversion
… writer to constant.py
|
We need a very small discussion on this matter since the functions changed were not |
|
@terazus Does "we" include me, or do you mean you guys? |
|
@ptth222 It means whoever wants to participate :) you are warmly welcome to discuss this with us. |
|
@terazus It can include me or not. I took "small discussion" to me like a voice communication meeting, so we would need to coordinate that if I needed to be in there. |
Fix to determining JSON directory location.
The last changes were initially tested and created on Windows, but had errors on GitHub. I fixed those errors, but didn't retest on Windows. This has been tested on both and is problem free.
Fixed parts of the code that needed to be changed to work with bytes. There are no more errors in testing.
ptth222
force-pushed
the
windows-to_csv-fix
branch
from
40579e1 to
0f7b791
Compare
|
Closing, dupe of #547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing dataframes using the to_csv method on Windows, blank rows are inserted after every row. There is a decent Stack Overflow post about the issue here: https://stackoverflow.com/questions/56398306/using-pandas-to-write-file-creates-blank-lines. The 2 best fixes are either to open the file in binary mode or don't open the file manually and just pass the filename to the method directly. I went through the package and found instances of "to_csv" usage and changed the opening style to "wb".
I initially only encountered this problem when writing study and assay files, so I know changing to "wb" fixes the issue there, but I did not test the other instances I found.