Fix rule and check. #524
Closed
Fix rule and check. #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialized in isatab2json conversion
The response[0] in core was setting what was supposed to be a list to a single string from the list instead. The check for whether a ontology source was in the list was nested beneath another check instead of being its own check.
|
Same comment as PR #526 : |
… test_isatab.py unchanged, added a TODO for reform tests
terazus
reviewed
Mar 1, 2024
|
Closing: dupe of #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the term_source_refs would be a single string like 'OBI' when it should have remained a list like ['OBI', 'NEWT']. The check_ontology_sources function returns a list, but for some reason the execute method in the Rule class was only taking the first value from the list instead of the whole list. I changed it to take the whole list.
This list was then used in the check_ontology_fields function, but the check that uses it was nested inside another. I believe this was in error, so I made the check independent.