Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule and check. #548

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

terazus
Copy link
Collaborator

@terazus terazus commented Mar 1, 2024

The response[0] in core was setting what was supposed to be a list to a single string from the list instead. The check for whether a ontology source was in the list was nested beneath another check instead of being its own check.

ptth222 and others added 2 commits January 30, 2024 17:06
The response[0] in core was setting what was supposed to be a list to a single string from the list instead. The check for whether a ontology source was in the list was nested beneath another check instead of being its own check.
@coveralls
Copy link

Coverage Status

coverage: 81.282% (-0.02%) from 81.298%
when pulling 9a5fb86 on ptth222:ontology-source-check-fix
into dbfa307 on ISA-tools:issue-511.

@ptth222
Copy link

ptth222 commented Mar 7, 2024

original_coverage_core
new_coverage_core
original_coverage_rules_30xx
new_coverage_rules_30xx

Here are screenshots of the new missing lines. I think the missing lines in rules/core.py are because this fix stopped exceptions from trying to access the 0th element in an empty list.

The new missing line in rules_30xx.py is from breaking the 2 tests into 2 separate if statements. The same check still isn't being tested just like before, there is just an extra line there now.

@terazus terazus mentioned this pull request Mar 11, 2024
@terazus terazus merged commit 16ccc00 into ISA-tools:issue-511 Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants