Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing getIsReplaying() method for Authoring API #7

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

julioalex-rezende
Copy link

@julioalex-rezende julioalex-rezende commented Jun 12, 2023

Description

Exposing getIsReplaying( ) method for Workflow Authoring API.
Tests that were using DurableTask SDK are now calling from Workflow's

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #TASK 46756

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link

@macromania macromania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌝

Copy link

@Aymalla Aymalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments

@julioalex-rezende julioalex-rezende merged commit dd81380 into master Jun 13, 2023
@julioalex-rezende julioalex-rezende deleted the julio/isReplayed branch June 13, 2023 13:41
@julioalex-rezende julioalex-rezende restored the julio/isReplayed branch June 13, 2023 15:29
@julioalex-rezende julioalex-rezende deleted the julio/isReplayed branch June 13, 2023 16:34
macromania pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com>
Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>
Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com>
macromania pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com>

Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com>
Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants