forked from mindlessroman/java-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing getIsReplaying() method for Authoring API #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julioalex-rezende
requested review from
macromania,
ross-p-smith,
Aymalla and
kusweta
June 13, 2023 07:52
macromania
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌝
Aymalla
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comments
sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowContext.java
Show resolved
Hide resolved
julioalex-rezende
force-pushed
the
julio/isReplayed
branch
from
June 13, 2023 12:22
ece1d16
to
1ecca7e
Compare
Aymalla
reviewed
Jun 13, 2023
sdk-workflows/src/test/java/io/dapr/workflows/runtime/DaprWorkflowContextImplTest.java
Show resolved
Hide resolved
sdk-workflows/src/test/java/io/dapr/workflows/runtime/DaprWorkflowContextImplTest.java
Show resolved
Hide resolved
macromania
pushed a commit
that referenced
this pull request
Jun 14, 2023
macromania
pushed a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com>
macromania
pushed a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Julio Rezende <jsilvarezend@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposing getIsReplaying( ) method for Workflow Authoring API.
Tests that were using DurableTask SDK are now calling from Workflow's
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #TASK 46756
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: