[TG Mirror] Simplemob AttackingTarget Fix [MDB IGNORE] #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
* Simplemob AttackingTarget Fix (#78966) Fixes #78953, plus some unreported code issues with lavaland elites, player-controlled megafauna, and a couple other hostile simplemobs. Basically, the sort of "attack wrapper" use of AttackingTarget seen in some simplemobs, specifically when player-controlled, was accidentally removed in the hands element refactor PR. This PR just re-adds that usage for player simplemobs to preserve previous functionality for our remaining simplemobs until their time to be refactored comes. While we're more geared towards basic mobs and simplemob conversions currently, we should still aim to preserve simplemob functionality until we don't have them anymore. :cl: fix: Space Dragon can break walls, eat corpses and destroy mechs more efficiently again fix: Player-controlled lavaland elites can once again return to their tumor after winning their fight /:cl: * Simplemob AttackingTarget Fix --------- Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
Fixes #78953, plus some unreported code issues with lavaland elites, player-controlled megafauna, and a couple other hostile simplemobs.
Basically, the sort of "attack wrapper" use of AttackingTarget seen in some simplemobs, specifically when player-controlled, was accidentally removed in the hands element refactor PR. This PR just re-adds that usage for player simplemobs to preserve previous functionality for our remaining simplemobs until their time to be refactored comes.
Why It's Good For The Game
While we're more geared towards basic mobs and simplemob conversions currently, we should still aim to preserve simplemob functionality until we don't have them anymore.
Changelog
🆑 IndieanaJones
fix: Space Dragon can break walls, eat corpses and destroy mechs more efficiently again
fix: Player-controlled lavaland elites can once again return to their tumor after winning their fight
/:cl: