You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using intl formatters, we may pass C as the locale which is not a valid ICU locale (note that this is not just gipfl specific). This was fine until a recent change in PHP, which now throws an exception in PHP >= 8.1.25. Since patching gipfl is not an option, we will simply replace it with using intl directly. Note that it is important not to use setlocale(..., 0) to pass the locale to intl, as this could pass C, which is invalid. I suggest just using null as this will automatically retrieve the default/set ICU locale, or Locale::getDefault() which does the same.
It also makes sense to replace strtotime() calls with new DateTime() where the code will change.
Upon creating a PR, make sure to also reference (resolve) the following issues:
When using
intl
formatters, we may passC
as the locale which is not a valid ICU locale (note that this is not justgipfl
specific). This was fine until a recent change in PHP, which now throws an exception in PHP >= 8.1.25. Since patchinggipfl
is not an option, we will simply replace it with usingintl
directly. Note that it is important not to usesetlocale(..., 0)
to pass the locale tointl
, as this could passC
, which is invalid. I suggest just usingnull
as this will automatically retrieve the default/set ICU locale, orLocale::getDefault()
which does the same.It also makes sense to replace
strtotime()
calls withnew DateTime()
where the code will change.Upon creating a PR, make sure to also reference (resolve) the following issues:
The text was updated successfully, but these errors were encountered: