From 512cc64d9095a77a0557d02ce4c3acd3a919a0b4 Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Tue, 29 Apr 2025 16:38:40 +0300 Subject: [PATCH 1/7] Fix cell editing sample missing grid ref --- samples/grids/grid/cell-editing-sample/src/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/grids/grid/cell-editing-sample/src/index.tsx b/samples/grids/grid/cell-editing-sample/src/index.tsx index 4ae9b8def1..494d0c759c 100644 --- a/samples/grids/grid/cell-editing-sample/src/index.tsx +++ b/samples/grids/grid/cell-editing-sample/src/index.tsx @@ -38,6 +38,7 @@ export default class Sample extends React.Component {
From 6ebcedfc19f934c873c22af47b44cc2217142ed5 Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Tue, 29 Apr 2025 16:39:02 +0300 Subject: [PATCH 2/7] Fix event binding and args of editing-excel-style sample --- samples/grids/grid/editing-excel-style/src/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/grids/grid/editing-excel-style/src/index.tsx b/samples/grids/grid/editing-excel-style/src/index.tsx index 81fcb3528c..0541ca6602 100644 --- a/samples/grids/grid/editing-excel-style/src/index.tsx +++ b/samples/grids/grid/editing-excel-style/src/index.tsx @@ -39,7 +39,7 @@ export default class Sample extends React.Component { autoGenerate={false} data={this.nwindData} primaryKey="ProductID" - gridKeydown={this.webGridEditingExcelStyle} + onGridKeydown={this.webGridEditingExcelStyle} ref={this.grid1Ref}> { return this._componentRenderer; } - public webGridEditingExcelStyle(sender: IgrGrid, args: IgrGridKeydownEventArgs): void { + public webGridEditingExcelStyle(args: IgrGridKeydownEventArgs): void { var key = (args.detail.event as any).keyCode; var grid = args.detail.target.grid; var activeElem = grid.navigation.activeNode; From eb4d72e3777b2e08329eeb19e742c6f07aac0bd0 Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Tue, 29 Apr 2025 16:50:31 +0300 Subject: [PATCH 3/7] Fix event binding and args of editing-events sample --- samples/grids/grid/editing-events/src/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/grids/grid/editing-events/src/index.tsx b/samples/grids/grid/editing-events/src/index.tsx index 9f3a13f1e0..8695a4054c 100644 --- a/samples/grids/grid/editing-events/src/index.tsx +++ b/samples/grids/grid/editing-events/src/index.tsx @@ -87,7 +87,7 @@ export default class Sample extends React.Component { return this._componentRenderer; } - public webGridEditingEventsCellEdit(sender: IgrGrid, args: IgrGridEditEventArgs): void { + public webGridEditingEventsCellEdit(args: IgrGridEditEventArgs): void { var d = args.detail; if (d.column != null && d.column.field == "UnitsOnOrder") { From 7e7572c838f132dca2e4efe525f8b38571f9723e Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Tue, 29 Apr 2025 17:30:01 +0300 Subject: [PATCH 4/7] Fix event binding of hgrid and treegrid cell-editing-sample --- .../grids/hierarchical-grid/cell-editing-sample/src/index.tsx | 1 + samples/grids/tree-grid/cell-editing-sample/src/index.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/samples/grids/hierarchical-grid/cell-editing-sample/src/index.tsx b/samples/grids/hierarchical-grid/cell-editing-sample/src/index.tsx index bd150fea91..91ac56d885 100644 --- a/samples/grids/hierarchical-grid/cell-editing-sample/src/index.tsx +++ b/samples/grids/hierarchical-grid/cell-editing-sample/src/index.tsx @@ -39,6 +39,7 @@ export default class Sample extends React.Component {
{ id="treeGrid1" data={this.roleplayTreeGridData} primaryKey="ID" + ref={this.treeGrid1Ref} foreignKey="ParentID"> Date: Tue, 29 Apr 2025 17:30:12 +0300 Subject: [PATCH 5/7] Fix event binding of hgrid and treegrid editing events sample --- samples/grids/hierarchical-grid/editing-events/src/index.tsx | 2 +- samples/grids/tree-grid/editing-events/src/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/grids/hierarchical-grid/editing-events/src/index.tsx b/samples/grids/hierarchical-grid/editing-events/src/index.tsx index 59089b244a..c47752ef8a 100644 --- a/samples/grids/hierarchical-grid/editing-events/src/index.tsx +++ b/samples/grids/hierarchical-grid/editing-events/src/index.tsx @@ -139,7 +139,7 @@ export default class Sample extends React.Component { return this._componentRenderer; } - public webGridEditingEventsCellEdit(sender: IgrHierarchicalGrid, args: IgrGridEditEventArgs): void { + public webGridEditingEventsCellEdit(args: IgrGridEditEventArgs): void { var d = args.detail; if (d.column != null && d.column.field == "UnitsOnOrder") { diff --git a/samples/grids/tree-grid/editing-events/src/index.tsx b/samples/grids/tree-grid/editing-events/src/index.tsx index 374219fa1c..bdb275cebe 100644 --- a/samples/grids/tree-grid/editing-events/src/index.tsx +++ b/samples/grids/tree-grid/editing-events/src/index.tsx @@ -85,7 +85,7 @@ export default class Sample extends React.Component { return this._componentRenderer; } - public webTreeGridCellEdit(sender: IgrTreeGrid, args: IgrGridEditEventArgs): void { + public webTreeGridCellEdit(args: IgrGridEditEventArgs): void { const column = args.detail.column; if (column.field === 'Age') { From 41fee53fe94ba24bbf024d83e9b9ab38ea8aa68d Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Wed, 30 Apr 2025 15:43:55 +0300 Subject: [PATCH 6/7] Fix multi-cell-selection-mode sample for grid --- .../grids/grid/multi-cell-selection-mode/src/index.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/samples/grids/grid/multi-cell-selection-mode/src/index.tsx b/samples/grids/grid/multi-cell-selection-mode/src/index.tsx index 89649c4b1b..4d8a9cc355 100644 --- a/samples/grids/grid/multi-cell-selection-mode/src/index.tsx +++ b/samples/grids/grid/multi-cell-selection-mode/src/index.tsx @@ -1,8 +1,8 @@ -import React, { useEffect, useRef, useState } from 'react'; +import React, { useRef } from 'react'; import ReactDOM from 'react-dom/client'; import './index.css'; -import { IgrGridBaseDirective, IgrGridCellEventArgs, IgrGridModule } from 'igniteui-react-grids'; +import { IgrGridModule, IgrGridSelectionRangeEventArgs } from 'igniteui-react-grids'; import { IgrGrid, IgrColumn } from 'igniteui-react-grids'; import { InvoicesData } from './InvoicesData'; @@ -19,15 +19,15 @@ export default function App() { const data = new InvoicesData(); const rightGridRef = useRef(null); - function onGridRangeSelected(grid: IgrGridBaseDirective): void { - rightGridRef.current.data = grid.getSelectedData(false, false); + function onGridRangeSelected(args: IgrGridSelectionRangeEventArgs): void { + rightGridRef.current.data = (args.target as any).getSelectedData(false, false); } return ( <>
- + From bca5da26368b82e8961c467680579e0ef2343ff1 Mon Sep 17 00:00:00 2001 From: Martin Dragnev Date: Wed, 30 Apr 2025 16:15:01 +0300 Subject: [PATCH 7/7] Fix multi-cell-selection-mode for tree grid as well --- .../tree-grid/multi-cell-selection-mode/src/index.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/grids/tree-grid/multi-cell-selection-mode/src/index.tsx b/samples/grids/tree-grid/multi-cell-selection-mode/src/index.tsx index b2c3f1f179..1fcda4bc2b 100644 --- a/samples/grids/tree-grid/multi-cell-selection-mode/src/index.tsx +++ b/samples/grids/tree-grid/multi-cell-selection-mode/src/index.tsx @@ -7,7 +7,7 @@ import { IgrTreeGridModule, IgrGridBaseDirective, } from "igniteui-react-grids"; -import { IgrGrid, IgrTreeGrid, IgrColumn } from "igniteui-react-grids"; +import { IgrGrid, IgrTreeGrid, IgrColumn, IgrGridSelectionRangeEventArgs } from "igniteui-react-grids"; import { EmployeesFlatData } from "./EmployeesFlatData"; import "igniteui-react-grids/grids/combined"; @@ -24,8 +24,8 @@ export default function App() { const leftTreeGridRef = useRef(null); const rightGridRef = useRef(null); - function handleTreeGridRangeSelectionChanged(grid: IgrGridBaseDirective) { - rightGridRef.current!.data = grid.getSelectedData( + function handleTreeGridRangeSelectionChanged(args: IgrGridSelectionRangeEventArgs) { + rightGridRef.current!.data = (args.target as any).getSelectedData( false, false ) as unknown as any[]; @@ -44,7 +44,7 @@ export default function App() { primaryKey="ID" foreignKey="ParentID" cellSelection="multiple" - rangeSelected={handleTreeGridRangeSelectionChanged} + onRangeSelected={handleTreeGridRangeSelectionChanged} >