Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skunk 1.0.0-M.x instead of 0.6.x #240

Open
lenguyenthanh opened this issue Jun 13, 2024 · 3 comments
Open

Use skunk 1.0.0-M.x instead of 0.6.x #240

lenguyenthanh opened this issue Jun 13, 2024 · 3 comments
Labels
breaking changes Changes that break compatibility with older versions enhancement New feature or request

Comments

@lenguyenthanh
Copy link

It seems the future of skunk will be on the line with 1.0.0-M.x, So, I think We should consider depend on skunk 1.0.0-M.x.

This is a breaking changes though, so maybe another module (iron-skunk-1.0) is a better idea.

@lenguyenthanh lenguyenthanh added the enhancement New feature or request label Jun 13, 2024
@Iltotore
Copy link
Owner

I'm not sure fracturing the module in two is a good idea. Maybe we can wait for Skunk 1.0.0. Also, how breaking are the changes between 0.x and 1.0.0-M.x?

@lenguyenthanh
Copy link
Author

lenguyenthanh commented Jun 13, 2024

how breaking are the changes between 0.x and 1.0.0-M.x?

They're binary incompatible so really breaking :D And I think the recommendation is to depends on 1.0.0 as this conversion: https://discord.com/channels/632277896739946517/839844929877704785/1250447183296335936

@Iltotore
Copy link
Owner

Then I think it's better to wait for the 1.0.0 release but remember I am not very familiar with Skunk so not very aware of the situation of Skunk users so feel free (or anyone else) to give advices.

@Iltotore Iltotore added the breaking changes Changes that break compatibility with older versions label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Changes that break compatibility with older versions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants