Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove private tabs from undo close history only after private browsing ends #112

Closed
Infocatcher opened this issue Nov 1, 2013 · 3 comments

Comments

@Infocatcher
Copy link
Owner

In addition for #6: we have secret extensions.privateTab.rememberClosedPrivateTabs preference to not remove private tabs from undo close history, so it's nice to have ability to cleanup undo close history after closing of last private tab/window.

Private data will be saved to the disk (since we can't alter built-in session restore mechanism), but this may be appropriate for some users.

Infocatcher added a commit that referenced this issue Nov 1, 2013
Usage:
rememberClosedPrivateTabs = true
rememberClosedPrivateTabs.enableCleanup = true
(draft for #112)
@Infocatcher
Copy link
Owner Author

Summary:

  • Set extensions.privateTab.rememberClosedPrivateTabs to true to not remove private tabs from undo close history.
  • Additionally set extensions.privateTab.rememberClosedPrivateTabs.cleanup to 1 or 2 (see notes in defaults/preferences/prefs.js about the difference) to cleanup undo close history only after last private tab/window will be closed.

But be careful: undo close history with private tabs will be saved to the disk!
The data will be overwritten later, but can be (probably) restored.

With recent commits any private data shouldn't be saved to the disk.

Infocatcher added a commit that referenced this issue Nov 21, 2013
Infocatcher added a commit that referenced this issue Dec 17, 2013
+ renamed preference:
rememberClosedPrivateTabs.enableCleanup (boolean) -> rememberClosedPrivateTabs.cleanup (integer)
(#112)
@Infocatcher
Copy link
Owner Author

Preference renamed:
rememberClosedPrivateTabs.enableCleanup (boolean) -> rememberClosedPrivateTabs.cleanup (integer)
(see changes in defaults/preferences/prefs.js)

P.S. Summary updated.

Infocatcher added a commit that referenced this issue Jan 10, 2014
Infocatcher added a commit that referenced this issue Jan 10, 2014
Infocatcher added a commit that referenced this issue Jan 10, 2014
rememberClosedPrivateTabs = true
+ rememberClosedPrivateTabs.cleanup = 0
(related to #112)
Infocatcher added a commit that referenced this issue Jan 10, 2014
(change "rememberClosedPrivateTabs.cleanup" from 0 to 1 or 2)
(#112)
@Infocatcher
Copy link
Owner Author

Note: private tabs aren't saved in undo close history in Firefox 29+:
https://bugzilla.mozilla.org/show_bug.cgi?id=899276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant