Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong appearance of hovered buttons after last tab (Australis) #138

Closed
Infocatcher opened this issue Apr 9, 2014 · 0 comments
Closed

Wrong appearance of hovered buttons after last tab (Australis) #138

Infocatcher opened this issue Apr 9, 2014 · 0 comments
Labels
bug compatibility fixed?

Comments

@Infocatcher
Copy link
Owner 

[Selected tab][Tab         ]|[New Private Tab (hovered)]
Wrong separator ------------^

Screenshot:
Screenshot

Also this separator will be hidden for hovered "New Tab" button.

See view-source:chrome://browser/content/tabbrowser.xml

        <xul:toolbarbutton class="tabs-newtab-button"
                           command="cmd_newNavigatorTab"
                           onclick="checkForMiddleClick(this, event);"
                           onmouseover="document.getBindingParent(this)._enterNewTab();"
                           onmouseout="document.getBindingParent(this)._leaveNewTab();"
                           tooltiptext="&newTabButton.tooltip;"/>
      <method name="_enterNewTab">
        <body><![CDATA[
          let visibleTabs = this.tabbrowser.visibleTabs;
          let candidate = visibleTabs[visibleTabs.length - 1];
          if (!candidate.selected) {
            this._beforeHoveredTab = candidate;
            candidate.setAttribute("beforehovered", "true");
          }
        ]]></body>
      </method>

      <method name="_leaveNewTab">
        <body><![CDATA[
          if (this._beforeHoveredTab) {
            this._beforeHoveredTab.removeAttribute("beforehovered");
            this._beforeHoveredTab = null;
          }
        ]]></body>
      </method>
Infocatcher added a commit that referenced this issue Apr 9, 2014
@Infocatcher
Correct "beforehovered" attribute on last tab
bf64ef6 
(for buttons after last tab)
(#138)
Infocatcher added a commit that referenced this issue Apr 9, 2014
@Infocatcher
Update changelog: #138
07c6252
Infocatcher added a commit that referenced this issue May 6, 2014
@Infocatcher
Correctly filter mouse events from buttons after tabs
c76aa6c 
for "beforehovered" attribute on last tab
Note: there also logical bug in old code:
if(btn.id == "tabbrowser-tabs")
(only tabs before buttons)
(#138, also related to #137)
Infocatcher added a commit that referenced this issue May 6, 2014
@Infocatcher
Remove obsolete codes around mouseover/mouseout on buttons after tabs
406acf0 
(#138)
Infocatcher added a commit that referenced this issue May 6, 2014
@Infocatcher
Update changelog: #138, again
1866c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility fixed?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher