-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e10s] Doesn't work with enabled Electrolysis (multi-process mode) #162
Comments
https://bugzilla.mozilla.org/show_bug.cgi?id=1114946 - "Private Tab" add-on does not work with e10s |
Also "private:" protocol doesn't work at all due to bug 940206 – nsIWebContentHandlerRegistrar::registerProtocolHandler doesn't work in e10s |
Also on Nightly there are some wrappers around |
With Private Tab enabled, I can't change favicon with javascript in firefox e10s tabs (private or not). The javascript works fine and the tabbar updates properly in non-e10s tabs. Here's a quick test script you can run in scratchpad: (function() { this may be a good resource: https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox |
I added a workaround for favicons: 06eab93 |
(still doesn't work, but now doesn't throw about security errors) (#162)
Some researches: toggleTabPrivate: function(tab, isPrivate, _silent) {
var window = tab.ownerDocument.defaultView;
var privacyContext = this.getTabPrivacyContext(tab);
if(!privacyContext) { // Electrolysis
//~ todo: use content script or something else to handle remote browser
_log("toggleTabPrivate(): getTabPrivacyContext() failed, will wait");
var observe = function(subject, topic, data) {
// Note: subject == tab.linkedBrowser.contentWindow is always false. Don't ask me, why.
_log("Created content document: " + subject.location);
if(subject.document == tab.linkedBrowser.contentDocument) {
Services.obs.removeObserver(observe, topic);
_log("Created content document: " + subject.location + "\nLet's try again");
this.toggleTabPrivate(tab, isPrivate, _silent);
}
}.bind(this);
Services.obs.addObserver(observe, "content-document-global-created", false);
return;
} And what we see? Cookies was already sent. :( |
Also too late to toggle private state: if(!privacyContext) { // Electrolysis
//~ todo: use content script or something else to handle remote browser
_log("toggleTabPrivate(): getTabPrivacyContext() failed, will wait");
var browser = tab.linkedBrowser;
var onTabReady = function(e) {
browser.removeEventListener("DOMWindowCreated", onTabReady, true);
_log("Received " + e.type + ", let's try again");
this.toggleTabPrivate(tab, isPrivate, _silent);
}.bind(this);
browser.addEventListener("DOMWindowCreated", onTabReady, true);
return;
} |
Test version: private_tab-0.1.8pre-fx-sm.xpi (source code). |
(better, but still doesn't work) (#162)
Favicons aren't displayed for tabs when Private Tabs in enabled on e10s latest nightlies. I've tried refreshing my profile, doesn't help |
Works fine for me... |
I had the same problem: Firefox 48.0a2 with e10s enabled and Private Tab 0.1.9.1. |
@Infocatcher If possible, please try to join their IRC channel on Tuesdays to report the problems still affecting Private Tab: |
* unsafe CPOW usage (#208) * updated pt-PT locale (#210) * e10s: fixed private protocol (#211) * e10s: tweaks and fixes (#162) * e10s: single frame script (#213) * fixed recursion in wrapper for tab.setAttribute("image", …) (#214) * compatibility with Firefox 51+: broked this.windows getter (#228) * small internal enhancements and fixes
* unsafe CPOW usage (#208) * updated pt-PT locale (#210) * e10s: fixed private protocol (#211) * e10s: tweaks and fixes (#162) * e10s: single frame script (#213) * fixed recursion in wrapper for tab.setAttribute("image", …) (#214) * compatibility with Firefox 51+: broked this.windows getter (#228) * small internal enhancements and fixes
* unsafe CPOW usage (#208) * updated pt-PT locale (#210) * e10s: fixed private protocol (#211) * e10s: tweaks and fixes (#162) * e10s: single frame script (#213) * fixed recursion in wrapper for tab.setAttribute("image", …) (#214) * compatibility with Firefox 51+: broked this.windows getter (#228) * small internal enhancements and fixes
Most of e10s-related bugs should be fixed: |
@Infocatcher That's great news. Thank you very much for your work on this extension and for not giving up despite all changes done by Mozilla. It's the one thing that keeps me on Firefox. |
See http://forums.mozillazine.org/viewtopic.php?p=13832477#p13832477
Also it's hard to work without fixed bug 1051238 – frame scripts are cached forever & thus can't be updated restartless.
Docs: https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox
Related issues:
The text was updated successfully, but these errors were encountered: