Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with another extension: list of closed tabs may become broken #197

Closed
sdavidg opened this issue Dec 23, 2015 · 2 comments
Closed

Conflict with another extension: list of closed tabs may become broken #197

sdavidg opened this issue Dec 23, 2015 · 2 comments
Labels
bug conflict with another addon

Comments

@sdavidg
Copy link

sdavidg commented Dec 23, 2015

  1. With a fresh profile install this addons:

https://addons.mozilla.org/en-US/firefox/addon/tab-mix-plus
https://addons.mozilla.org/en-US/firefox/addon/private-tab
https://addons.mozilla.org/en-US/firefox/addon/findbar-tweak

  1. Change extensions.privateTab.rememberClosedPrivateTabs to true
  2. Restart firefox
  3. Go to this page: https://github.com/Infocatcher
  4. Open two tabs via ctrl+click on any link
  5. Open two private tabs
  6. Go to any private tab and press ctrl+F
  7. Close tab
    9.a) Press ctrl+shift+t --> error console shows "TypeError: cyclic object value"
    9.b) Rigth-click on tab and go to "close tab list" --> List is empty and error console shows "TypeError: cyclic object value"
    sin titulo
@Infocatcher Infocatcher changed the title Conflict with another extension Conflict with another extension: list of closed tabs may become broken Dec 26, 2015
Infocatcher added a commit that referenced this issue Dec 26, 2015
@Infocatcher
Correctly fill TabState.permanentKey to restore closed tabs
d526f93 
(bug in cb93d3a commit)
(#197, related to #146)
Infocatcher added a commit that referenced this issue Dec 26, 2015
@Infocatcher
Update changelog: #197 (correctly save closed private tabs)
3eeae24
@Infocatcher
Copy link
Owner

Looks fixed for me after d526f93 commit.
Oh, now required xpinstall.signatures.required = false to test anything not signed. :(

@sdavidg
Copy link
Author

sdavidg commented Dec 28, 2015

Works perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug conflict with another addon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infocatcher @sdavidg