Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open bookmark folder in new private tabs? #99

Closed
ivysrono opened this issue Sep 7, 2013 · 3 comments
Closed

open bookmark folder in new private tabs? #99

ivysrono opened this issue Sep 7, 2013 · 3 comments

Comments

@ivysrono
Copy link

ivysrono commented Sep 7, 2013

Would you support it?

@Infocatcher
Copy link
Owner

I'll look at it.
Firefox has too many codes for "Open All in Tabs":

<menuitem
    id="placesContext_openContainer:tabs"
    oncommand="var view = PlacesUIUtils.getViewForNode(document.popupNode); view.controller.openSelectionInTabs(event);"
    onclick="checkForMiddleClick(this, event);"
    label="Open All in Tabs"
    accesskey="O"
    selectiontype="single"
    selection="folder|host|query" />
<menuitem
    id="placesContext_openLinks:tabs"
    oncommand="var view = PlacesUIUtils.getViewForNode(document.popupNode); view.controller.openSelectionInTabs(event);"
    onclick="checkForMiddleClick(this, event);"
    label="Open All in Tabs"
    accesskey="O"
    selectiontype="multiple"
    selection="link" />

=>

  function PC_openLinksInTabs(aEvent) {
    var node = this._view.selectedNode;
    if (node && PlacesUtils.nodeIsContainer(node))
      PlacesUIUtils.openContainerNodeInTabs(this._view.selectedNode, aEvent, this._view);
    else
      PlacesUIUtils.openURINodesInTabs(this._view.selectedNodes, aEvent, this._view);
  }

=> too many things inside PlacesUIUtils.openContainerNodeInTabs() and PlacesUIUtils.openURINodesInTabs()

So it's easy, but only if there is a way to reuse these codes somehow.

@Infocatcher
Copy link
Owner

Test version: private_tab-0.1.6pre1-fx-sm.xpi (source).

@ivysrono
Copy link
Author

thanks,it is ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants