Bug fix TOD orientation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florent2305
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Good job to find the bug and retrive the solution into the Thomas' code.
Please, change some few coding styles. After I will wait the review of @astamm then I will merge it.
Thank you for your feedback, I created a new commit where I added the curly brackets. |
|
Thanks It's fine for me. I wait @astamm review. |
Florent2305
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added again lines of code written by Thomas Durantel @todurante which had then been removed.
Without these lines, we have an orientation error with the TODs estimated by animaTODEstimator (a flip in x axis).