From 688e05c2c86d8ab07002966d0cc1e1bccea98266 Mon Sep 17 00:00:00 2001 From: Fabio Catinella Date: Tue, 27 Aug 2024 14:39:43 +0200 Subject: [PATCH] fix: Removed "it" from forbiddenKeywords and replace "" with "_ -> " when generating params string in case of no injected params. Fixes gh-161 (koin-annotations) --- .../kotlin/org/koin/compiler/generator/DefinitionWriter.kt | 2 +- .../src/jvmMain/kotlin/org/koin/compiler/scanner/ext/KspExt.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/generator/DefinitionWriter.kt b/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/generator/DefinitionWriter.kt index ff1d64ba..b905177e 100644 --- a/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/generator/DefinitionWriter.kt +++ b/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/generator/DefinitionWriter.kt @@ -95,7 +95,7 @@ class DefinitionWriter( } private fun List.generateParamFunction(): String { - return if (any { it is KoinMetaData.DefinitionParameter.ParameterInject }) "params -> " else "" + return if (any { it is KoinMetaData.DefinitionParameter.ParameterInject }) "params -> " else "_ -> " } private fun String?.generateQualifier(): String = when { diff --git a/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/scanner/ext/KspExt.kt b/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/scanner/ext/KspExt.kt index 15ba836f..a713942c 100644 --- a/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/scanner/ext/KspExt.kt +++ b/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/scanner/ext/KspExt.kt @@ -138,7 +138,7 @@ internal fun List.getValueArgument(): String? { fun KSClassDeclaration.getPackageName() : String = packageName.asString() -val forbiddenKeywords = listOf("interface","it") +val forbiddenKeywords = listOf("interface") fun String.filterForbiddenKeywords() : String{ return split(".").joinToString(".") { if (it in forbiddenKeywords) "`$it`" else it