Skip to content

ENH: Add example derivativeImage #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2022
Merged

ENH: Add example derivativeImage #380

merged 2 commits into from
Jul 5, 2022

Conversation

@labdala
Copy link
Contributor

@labdala labdala commented May 20, 2022

No description provided.

@github-actions github-actions bot added area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:C++ Changes to C++ examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels May 20, 2022
tbirdso
tbirdso suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 💯 One request below.

@tbirdso
Copy link
Contributor

tbirdso commented May 22, 2022

For reference, warnings from build-test-documentation or other CI pipelines can be found in CDash. When you have time to revisit in the next few days or weeks, the following changes should let checks on this PR pass:

  1. Address style warnings in ImageFeature/DerivativeImage/Documentation.rst
  2. Add an entry for DerivativeImage/Documentation.rst to ImageFeature/Documentation.rst
  3. Take .png screenshots of .mha output data in an image viewer such as 3D Slicer, then replace the .mha images referenced in ImageFeature/DerivativeImage/Documentation.rst with those .png screenshots.

@labdala
Copy link
Contributor Author

labdala commented Jul 5, 2022 •
edited
Loading

Thank you for your suggestions @tbirdso ! They were very helpful.

tbirdso
tbirdso approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @labdala !

@tbirdso tbirdso merged commit ff92cc6 into InsightSoftwareConsortium:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tbirdso tbirdso tbirdso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:C++ Changes to C++ examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labdala @tbirdso