IGListAdapter: Fix not returning early when collectionView/dataSource is nil and completion is nil #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This was referenced Oct 12, 2016
|
Attempting to fix the spurious CocoaPods failures in #57 |
rnystrom
reviewed
Oct 12, 2016
| @@ -103,14 +103,14 @@ IGLK_SUBCLASSING_RESTRICTED | |||
| - (void)performUpdatesAnimated:(BOOL)animated completion:(nullable IGListUpdaterCompletion)completion; | |||
|
|
|||
| /** | |||
| Perform an immediate reload of the data in the data source, discarding the old objectss. | |||
|
@benasher44 thanks for fixing the builds! We had a scramble to get all the public CI stuff working yesterday 😅 Awesome find here! |
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Np! |
|
lol, nice find! |
|
👏 🙌 |
Closed
benasher44
added a commit
to benasher44/IGListKit
that referenced
this pull request
Oct 13, 2016
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2016
Summary: Fixed #63. I used the style we use in CocoaPods, but I'm happy to adjust! - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes #67 Reviewed By: jessesquires Differential Revision: D4015999 Pulled By: rnystrom fbshipit-source-id: bbe8055f22e84c5bdc628b4c1d95dab111774e12
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2016
Summary: - Travis appears to be using CocoaPods 1.1.0.beta.2, which is missing some fixes for Xcode 8 (see [sample failing build](https://travis-ci.org/Instagram/IGListKit/jobs/166935850) from #51). - This change will ensure that a consistent CocoaPods version is used by Travis - In the added Gemfile, I picked the latest CocoaPods 1.1.0 RC (matches version in Podfile.lock) and the latest xcpretty. - Changed `pod spec lint` to `pod lib lint` to verify local files instead of files from the version specified in the spec. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes #57 Differential Revision: D4019655 Pulled By: rnystrom fbshipit-source-id: 422e55c44dfdf276b587ea6e12ae30218a237ff5
bogren
pushed a commit
to bogren/IGListKit
that referenced
this pull request
Aug 3, 2017
Summary: - Travis appears to be using CocoaPods 1.1.0.beta.2, which is missing some fixes for Xcode 8 (see [sample failing build](https://travis-ci.org/Instagram/IGListKit/jobs/166935850) from Instagram#51). - This change will ensure that a consistent CocoaPods version is used by Travis - In the added Gemfile, I picked the latest CocoaPods 1.1.0 RC (matches version in Podfile.lock) and the latest xcpretty. - Changed `pod spec lint` to `pod lib lint` to verify local files instead of files from the version specified in the spec. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes Instagram#57 Differential Revision: D4019655 Pulled By: rnystrom fbshipit-source-id: 422e55c44dfdf276b587ea6e12ae30218a237ff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
reloadDataWithCompletion:where it looks like we meant to bail out early if thecollectionViewordataSourceis nil, but it only does so ifcompletionis provided.Pull request checklist
Notes
Questions
collectionViewmight make it somewhere it shouldn't have). Should I add a test anyway?