Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notes sync error handling #13

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Improve notes sync error handling #13

merged 1 commit into from
Jan 15, 2024

Conversation

jparise
Copy link
Member

@jparise jparise commented Jan 15, 2024

We no longer persist the sync cursor if the sync encounters an error. This feels safer than the previous approach of always updating the cursor.

We also ensure that the "notes sync in progress" is cleared after the sync completes (for both successes and failures).

We no longer persist the sync cursor if the sync encounters an error.
This feels safer than the previous approach of always updating the
cursor.

We also ensure that the "notes sync in progress" is cleared after the
sync completes (for both successes and failures).
@jparise jparise merged commit b7713ac into main Jan 15, 2024
1 check passed
@jparise jparise deleted the notes-sync-try branch January 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant