Added tests to cover red lines in coverage report #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caught a bug and fixed it.
Improved validation for the routine computing strides of the new reshaped array for a view, or None if view is not possible. This fixes an exception raised for ``` X = dpt.usm_ndarray((1,), "i4") X.shape = (1,) # used to raise, not works as expected ```
oleksandr-pavlyk
force-pushed
the
improve_copy_utils_coverage
branch
from
a13a1fb to
346392e
Compare
oleksandr-pavlyk
force-pushed
the
improve_copy_utils_coverage
branch
from
90d1e90 to
2315489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught few bugs and fixed them in the process as a perk.