Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang format to pre-commit config #1450

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Add clang format to pre-commit config #1450

merged 3 commits into from
Jun 22, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 21, 2023

The PR proposes to extend pre-commit configuration with clang tool.

There is a hard dependency to run the check with clang-format-12, since it is the latest version available for Ubuntu 20.04.
Need to note that different versions of clang-format might be incompatible with each other and so format C++ code differently.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jun 21, 2023
.clang-format Outdated Show resolved Hide resolved
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank @antonwolfy

@antonwolfy antonwolfy merged commit ae755b5 into master Jun 22, 2023
@antonwolfy antonwolfy deleted the add_clang_format branch June 22, 2023 09:16
@antonwolfy antonwolfy mentioned this pull request Jul 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants