Skip to content

impl_usage_dpctl_bitwise_op #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vtavana merged 2 commits into from
Aug 16, 2023
Merged

impl_usage_dpctl_bitwise_op #1508

vtavana merged 2 commits into from
Aug 16, 2023

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Aug 4, 2023 •
edited
Loading

The PR uses dpctl.tensor implementation for bitwise_and, bitwise_or, bitwise_xor, invert, left_shift, and right_shift functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana self-assigned this Aug 4, 2023
antonwolfy
antonwolfy reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also keep in mind and update tests/third_party/cupy/binary_tests/test_elementwise.py::TestElementwise and to try to replace @testing.for_dtypes(...) with @testing.for_int_dtypes() there, once the last bitwise op is done.

@vtavana vtavana force-pushed the use_dpctl_bitwise_op branch 6 times, most recently from 1c7c397 to 20bf44e Compare August 8, 2023 12:06
@vtavana vtavana marked this pull request as ready for review August 8, 2023 15:12
antonwolfy
antonwolfy reviewed Aug 8, 2023
View reviewed changes
antonwolfy
antonwolfy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@vtavana vtavana force-pushed the use_dpctl_bitwise_op branch from d2cd551 to 7bcc426 Compare August 10, 2023 13:22
oleksandr-pavlyk
oleksandr-pavlyk reviewed Aug 14, 2023
View reviewed changes
@vtavana vtavana force-pushed the use_dpctl_bitwise_op branch 4 times, most recently from 77bb04d to 2cd3fb0 Compare August 14, 2023 15:56
@vtavana vtavana force-pushed the use_dpctl_bitwise_op branch from 2cd3fb0 to 3e33dd9 Compare August 16, 2023 13:04
@vtavana vtavana force-pushed the use_dpctl_bitwise_op branch from 3e33dd9 to b60eb41 Compare August 16, 2023 13:07
@vtavana vtavana merged commit 42e02d9 into master Aug 16, 2023
@vtavana vtavana deleted the use_dpctl_bitwise_op branch August 16, 2023 15:14
vtavana added a commit that referenced this pull request Aug 16, 2023
@vtavana
Merge pull request #1508 from IntelPython/use_dpctl_bitwise_op
bde1b43 
impl_usage_dpctl_bitwise_op
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

+1 more reviewer

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @oleksandr-pavlyk @antonwolfy