Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leveraged dpctl.tensor.stack() implementation #1509

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 7, 2023

The PR propose to rework implementation of dpnp.stack() to fully rely on dpctl.tensor.stack.
New tests are added to secure stack function behavior.

Additionally, a scope of tests included in public CI verification is extended with array manipulation tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @antonwolfy

@antonwolfy antonwolfy merged commit 0a45a54 into master Aug 7, 2023
@antonwolfy antonwolfy deleted the dpctl_stack branch August 7, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants