Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntelSYCL cmake script #1611

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Use IntelSYCL cmake script #1611

merged 2 commits into from
Oct 31, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 30, 2023 •
edited
Loading

Replaced deprecated IntelDPCPPConfig.cmake vendored script with vendored IntelSYCLConfig.cmake.

Changed project's cmake scripts accordingly.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review October 30, 2023 13:32
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @antonwolfy

@antonwolfy antonwolfy merged commit d389bd4 into master Oct 31, 2023
22 checks passed
@antonwolfy antonwolfy deleted the switch_to_IntelSYCL branch October 31, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev