Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented BLAS backend for work with oneMKL Interfaces #1981

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

npolina4
Copy link
Collaborator

Implemented build for NVIDIA GPU:
Implemented BLAS backend for work with oneMKL Interfaces.

BLAS from oneMKL Interfaces cannot call onemkl::blas::row_major. Changed by calling onemkl::blas::column_major

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1981/index.html

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @npolina4!

@npolina4 npolina4 merged commit 6f3d5f5 into master Aug 26, 2024
38 of 46 checks passed
@npolina4 npolina4 deleted the build_target_cuda_blas1 branch August 26, 2024 20:39
github-actions bot added a commit that referenced this pull request Aug 26, 2024
* Implemented BLAS backend for work with oneMKL Interfaces

* update gemm

* Update gemv

* Update gemv_impl

* Update gemm_batch

* Fix pre-commit

* updates to remove duplication

* fix two issues: 1) when order is given as "A" 2) when axes is given and column_major is called

---------

Co-authored-by: Vahid Tavanashad <vahid.tavanashad@intel.com>
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 6f3d5f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants