Skip to content

Conversation

@carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 25, 2025

Changelog

- description: |
    Fix missing zlib in WASM nix shell
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
  projects:
  - cardano-wasm

Context

For some reason haskell package digest was trying to find zlib in pkg-config output, which does not succeed on WASM platform. We can tell it to not use pkg-config for that: https://hackage.haskell.org/package/digest-0.0.2.1

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles...
Thank you 🙂

@carbolymer carbolymer added this pull request to the merge queue Jul 25, 2025
Merged via the queue into master with commit 4a6ce60 Jul 25, 2025
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/fix-missing-zlib-in-wasm-shell branch July 25, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants