Don't overflow on complex constructor #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCSharp
reviewed
Apr 5, 2022
Member
BCSharp
left a comment
BCSharp
left a comment
There was a problem hiding this comment.
Glad you noticed that. While reviewing this PR, I've noticed that ParseComplex doesn't handle null chars correctly like ParseFloat does.
>>> complex("1111\x00")
(1111+0j)
>>> complex("1111\x00j")
1111jThe above should raise ValueError: complex() arg is a malformed string. Perhaps replacing ParseFloadNoCatch in ParseComplex with ParseFloat would do the trick.
BCSharp
approved these changes
Apr 6, 2022
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reviewing #1385