Use Nodes instead of our custom FedoraResource entity

[dannylamb]

This is a long-term strategic move to more closely align islandora with the Drupal community. Drupal expects/wants you to use nodes and media to model your content (Media is becoming core in 8.4), so by falling in line we will open up access to a larger swathe of contributed modules and open up islandora to a much larger user community.

This is a large shift that will require PRs against all of our Drupal modules.

• Remove the custom FedoraResource entity from the core islandora module. Any special actions done in response to entity CRUD events will need to get shuffled into node hooks. Remove any custom UI work for the admin/content menu.
• Re-model collections in islandora_collection and re-export
• Re-model images in islandora_image and re-export

We can possibly use the config:export:content:type (cect) command with the Drupal console to do those re-exports.

[whikloj]

We also need to dump

• Create DigtialOcean and Amazon AWS provider options for Vagrant install #52
• isConstituentOf is missing from list of Islandora RELS-EXT predicates #40

[dannylamb]

@whikloj We still need to create Content Entities using RDF. So those pulls are still totally relevant. We just need to make them work with Nodes instead.

[dannylamb]

I've got this roughly working with nodes and have re-exported the core and collection yaml. When I've got images re-exported i'll issue PRs for all three so people can take a test drive.

[dannylamb]

You can totally run through these commands and check everything out, but #649 will need to get resolved before things will flush to Fedora again. Just a heads up.

The PRs for this issue are:

• Revert "increment version to 0.0.1-SNAPSHOT" #63
• https://github.com/Islandora-CLAW/islandora_collection/pull/21
• Issue 643 islandora-deprecated/islandora_image#14

Testing Instructions

• Uninstall the islandora_image, islandora_collection, and islandora modules. You will need to delete any existing FedoraResource entities before doing so. If you uninstall through the web interface at /admin/modules/uninstall it will help do this for you.
• vagrant ssh into your environment
• Update the islandora module from my fork using git
  • cd /var/www/html/drupal/web/modules/contrib/islandora
  • git remote add danny https://github.com/dannylamb/islandora.git
  • git fetch danny
  • git checkout issue-643
• Update the islandora_collection module from my fork using git
  • cd /var/www/html/drupal/web/modules/contrib/islandora_collection
  • git remote add danny https://github.com/dannylamb/islandora_collection.git
  • git fetch danny
  • git checkout issue-643
• And repeat those commands one more time for islandora_image
  • cd /var/www/html/drupal/web/modules/contrib/islandora_image
  • git remote add danny https://github.com/dannylamb/islandora_image.git
  • git fetch danny
  • git checkout issue-643
• Install the islandora image module. This will install the other two modules for you since they're declared as dependencies
• To add content, click the 'Add Content' link in the menu, or click the Content button in the admin toolbar to navigate to /admin/content
  
• You'll notice there is no 'Fedora Resource' tab anymore. We're using nodes, so click the blue + Add Content button to be brought to the list of available content types.
  
• Click on Islandora Collection to create a collection
  
• Fill out the form and click the blue Save and Publish button
  
• You'll notice that I've replaced the Members tab with a block underneath the content. This saves a click for the end user and also works around https://www.drupal.org/node/2489932, which was making the Members tab appear on all bundles even when explictly told not to.
  
• Now make an image by going back to /admin/content, clicking the blue + Add Content, and clicking Islandora Image
• Fill out the form and make it a member of the previously created collection.
  
• Check out your newly created image
  
• Navigate back to your collection, and the Members block should be populated
  

Wanna get really crazy?

• Enable the devel_generate module
• Go to /admin/config and click on Generate media to be brought to /admin/config/development/generate/media
• Generate media for all of our defined types
  
• Now go to /admin/config and click on Generate contet to be brought to /admin/config/development/generate/content
• Generate content for all of our defined types
  
• Go to the homepage and look at all that content.
  

[ruebot]

Tested and all works as expected. Really great to be able to use generate content to test out now. Nodes open up a really nice world in Drupal that I've been missing for about 10 years now 😄

[whikloj]

👍 All 3 work as expected.

We'll need to consider whether an islandora_image that is saved but not published should be synced to Fedora.

[whikloj]

@ruebot you go ahead and pull the trigger on these 3 PRs if everyone is ready. Then we need to fix our Travis setup.

[kimpham54]

Tested all 3 pull requests. Everything works as expected, except when I test devel generate content it generates txt files as the OBJ and JP2 for Islandora Images. Is there a way to get it to generate images like it does for MEDIUM_SIZE and TN?

Thanks for the clear instructions @dannylamb

[whikloj]

Hey @kimpham54, that is because @dannylamb had to use generic "file" media entities instead of "image" media entities. The "image" media entities don't seem to work very well with JP2 or TIFF images.

…

On 1 Jun 2017 1:59 am, "kim pham" ***@***.***> wrote: Tested all 3 pull requests. Everything works as expected, except when I test devel generate content it generates txt files as the OBJ and JP2 for Islandora Images. Is there a way to get it to generate images like it does for MEDIUM_SIZE and TN? Thanks for the clear instructions @dannylamb <https://github.com/dannylamb> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#643 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACua4edvo-kNi6juc483ZqfyQNe_RobYks5r_mFIgaJpZM4NlEu5> .

[ruebot]

Thanks for testing y'all. I'm going to merge these.

[ruebot]

Resolved with:
07f69a8
https://github.com/Islandora-CLAW/islandora_collection/commit/2f204f3425bf571eccac0c348485b72f4f505738
islandora-deprecated/islandora_image@e0fab4a

[dannylamb]

@kimpham54 Ha! That's awesome you actually checked out those files. I guess it does text as a sensible default.

[dannylamb]

#64 might fix it. We can revert #652 if that's the case.

[dannylamb]

Finally closed with #65