Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out internal roles in claw-playbook #743

Closed
13 tasks done
dannylamb opened this issue Nov 6, 2017 · 16 comments
Closed
13 tasks done

Break out internal roles in claw-playbook #743

dannylamb opened this issue Nov 6, 2017 · 16 comments
Assignees

Comments

@dannylamb
Copy link
Contributor

dannylamb commented Nov 6, 2017

In order to get them on galaxy and use them in more complicated multi-server setups, we need to break out our internal roles into their own github repositories in the Islandora-Devops organization.

Current list of roles:

@whikloj
Copy link
Member

whikloj commented Nov 8, 2017

@dannylamb You want that I should make repos in the Islandora-DevOps organization for each of these? Is there a naming structure to follow?

@dannylamb
Copy link
Contributor Author

Yeah, that'd be great. Riffing from claw-playbook I guess we're hyphenating instead of underscoring? I checked galaxy and there didn't seem to be a discernible convention.

@whikloj whikloj self-assigned this Nov 9, 2017
@whikloj
Copy link
Member

whikloj commented Nov 9, 2017

Okay as a note, to find out what platforms are available you can use this API
https://galaxy.ansible.com/api/v1/platforms/?format=api&name=Ubuntu
Not well documented, but there is a Github issue open that lead to it.

Also what versions of each platform do we want to support and test with? For instance, the above link list 16 versions for Ubuntu.

@whikloj
Copy link
Member

whikloj commented Nov 9, 2017

Also tags..."Islandora" or "CLAW" or "Islandora-CLAW"?

@whikloj
Copy link
Member

whikloj commented Nov 9, 2017

Actually tags are a single alpha-numeric term, so for Fedora I'm going with

tags:
   - fedora
   - islandora
   - CLAW
   - repository
   - ldp
   - installer

@dannylamb
Copy link
Contributor Author

@whikloj We're targeting Ubuntu xenial and Centos 7. I'm assuming this is for advertising what they work on?

@whikloj
Copy link
Member

whikloj commented Nov 9, 2017

OK, then we target Ubuntu and Enterprise_Linux
Which seems to be Centos/RHEL... I think

@whikloj
Copy link
Member

whikloj commented Nov 9, 2017

Pardon that is EL not Enterprise_Linux

@whikloj
Copy link
Member

whikloj commented Nov 10, 2017

All split out however I'm wondering if this is an ActiveMQ role that we could put some effort behind.

Has some downloads, but is missing xenial support. We could fork it and if it works provide some PRs.

I have made the a repo for activemq, so if they are non-responsive we won't have lost this work.

Thoughts?

Also, I like one of the conventions out there which is providing variables for major, minor and patch version number.

Lastly, now I am going to start with some clean up as I found some variable bleed between roles. Perhaps I'll see if I can figure out how to write some tests and use that molecule thing @DiegoPino pointed out.

@jonathangreen
Copy link
Contributor

Should probably make a PR to remove the broken out roles from claw-playbook, and to add them to requirements.yml so we pull in our own roles from galaxy. I guess making a release for each of them is probably a good idea too. That maybe could be another ticket, just wanted to add my 2c.

@whikloj
Copy link
Member

whikloj commented Nov 10, 2017

@jonathangreen Don't they need to be in galaxy before we can pull them in? Just because I think @dannylamb will need to create the islandora user account to get the nice islandora.role-name names.

@dannylamb
Copy link
Contributor Author

@whikloj They may just have tags wrong in ansible-galaxy. According to the repo's README it supports 16.04? Maybe we should just give it a try.

I'll go make an account for islandora.

@whikloj
Copy link
Member

whikloj commented Nov 14, 2017

molecule while interesting doesn't work out of the box on my Mac. It could be my docker setup. But I'm not sure.

I was following this post which led me to start this branch which is a good start (if I do say so myself).

However we will need to consider docker and something along the lines of (but hopefully way simpler than) this
https://www.jeffgeerling.com/blog/2016/how-i-test-ansible-configuration-on-7-different-oses-docker

@whikloj
Copy link
Member

whikloj commented Nov 14, 2017

@jonathangreen
Copy link
Contributor

Whenever we are pulling the roles out, we need to make sure we sync them up first. There are probably other changes, but I wanted to make sure these two PR don't get lost:
Islandora-Devops/islandora-playbook#31
Islandora-Devops/islandora-playbook#32

@jonathangreen
Copy link
Contributor

I think we can call this closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants