Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an 'Agent' content type #897

Closed
dannylamb opened this issue Aug 20, 2018 · 13 comments
Closed

Create an 'Agent' content type #897

dannylamb opened this issue Aug 20, 2018 · 13 comments
Assignees

Comments

@dannylamb
Copy link
Contributor

Blocked by #893 and #889

Using https://docs.google.com/spreadsheets/d/18u2qFJ014IIxlVpM3JXfDEFccwBZcoFsjbBGpvL0jJI/edit#gid=0 for guidance, make a new content type for 'Agents' (you can name it whatever we collectively feel is best, we're not beholden to 'Agent') to be populated from MODS name elements. You'll want to make the 'role' field a taxonomy term reference to the MARC Relators vocabulary created in #893. You'll also want the relator term chosen to dictate the rdf:type of the 'Agent', so you'll also need to wait for #889.

@DigitLib
Copy link

Signed!

@rtilla1
Copy link

rtilla1 commented Aug 20, 2018

Sprint Kick-off: Similar to #894 . Should be fairly straightforward.

@rosiel
Copy link
Member

rosiel commented Aug 20, 2018

To explain the MIG's spreadsheet, the section called "Minted Elements: Name" lists some fields that we'd like to be able to model - as these are names coming from MODS, we'll want some namePart equivalents as well as a "displayForm". Yes - potentially duplicating data.

@seth-shaw-unlv seth-shaw-unlv self-assigned this Aug 20, 2018
@seth-shaw-unlv
Copy link
Contributor

I humbly submit this module as the basis for Agents. It includes content models for Corporate Body, Person, and Family.

@DigitLib
Copy link

@seth-shaw-unlv TNX!! so we can use it to expand it according a doc?

@seth-shaw-unlv
Copy link
Contributor

Yes. I'm not tied to anything in that module. I would prefer we add the module as an islandora demo dependency, then we can issue PRs against that repo. (I would like to keep it a distinct repo because I am using it in another project too.)

Also, if the Islandora community would like, we can simply transfer the repo to Islandora.

@DigitLib
Copy link

@seth-shaw-unlv we'll see what @dannylamb has in mind for this it would be goo to have a module for this with a defined RDF

@dannylamb
Copy link
Contributor Author

@seth-shaw-unlv That is a great starting point for agents. We might want to take this as an opportunity to do some housekeeping. We could break the demo feature off into its own github repo and either roll in the config from controlled_access_terms or export it as a separate feature but put it in the same repo.

Then whatever applicable code is in controlled_access_terms should probably get rolled into the core islandora module.

@seth-shaw-unlv
Copy link
Contributor

@dannylamb my preference would be

  • islandora_demo as a separate repo
  • controlled_access_terms as a separate repo, listed as a dependency for islandora_demo so it can be used with the 7x migration content models.
  • the new TypedRelation field and related code in the jsonld repo (that way other non-islandora projects can use it)

@dannylamb
Copy link
Contributor Author

@seth-shaw-unlv I'm pushing through your first two bullet points now. I've left the code in controlled_access_terms, and we can shuffle it out in a PR no prob. Although as it stands right now it looks like controlled_access_terms is totally islandora independent anyway?

@seth-shaw-unlv
Copy link
Contributor

Yes, @dannylamb, I intended it to be independent of islandora because it is also being used in an archivesspace/drupal integration module.

That stated, I'm also trying to keep that archivesspace/drupal project in line with islandora so they can be easily used together.

@dannylamb
Copy link
Contributor Author

@seth-shaw-unlv I'd prefer to keep it that way too. One of the hardest struggles of this project has been to define the code boundaries. Keeping everything as independent as possible is the way to go.

@dannylamb
Copy link
Contributor Author

controlled_access_terms satisfies this issue, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants