Update to 18.04 #125
Update to 18.04 #125
Conversation
- Update Vagrantfile to use 18.04 for Ubuntu builds - Tweak package names, and required packages for 18.04 - Updates to get rid of some deprecation warnings - Addresses Islandora/documentation#848 - Requires islandora-deprecated/ansible-role-grok#6
|
|
|
failed on installing grok. did any underlying roles change? |
|
Did you get the islandora-deprecated/ansible-role-grok#6 ? |
|
Bingo. Read the PR description Danny.... |
|
Ok, let's try this again 🤦♂️ |
|
@Natkeeran I'll update on Friday, when I'm back at York. |
|
With islandora-deprecated/ansible-role-grok#6 I'm getting TASK [Islandora-Devops.grok : Install Grok dependencies (apt)] *****************
Monday 15 July 2019 16:51:50 -0300 (0:00:02.767) 0:35:07.447 ***********
failed: [default] (item=[u'cmake', u'libpng16-dev', u'libtiff-dev', u'liblcms2-dev']) => {"ansible_loop_var": "item", "changed": false, "item": ["cmake", "libpng16-dev", "libtiff-dev", "liblcms2-dev"], "msg": "No package matching 'libpng16-dev' is available"}
|
|
Not sure on the proper procedure for testing Ansible Playbooks with internal/external roles, but what I did locally was to edit |
|
Updated locally, and testing with the changes @Natkeeran requested #125 (comment) |
|
Tested with 16f2e43, and things appear to be good. |
|
FWIW I deleted the role and then updated requirements.yml to point to the branch for the PR. Let me try again. |
|
Yeah... turns out that when you provision a remote environment, it caches the roles in So that wold explain lots of things. Sorry @ruebot. Let's try this again. |
|
Three derps later and I finally got it. Provisions fine and passes my smoke tests. I merged islandora-deprecated/ansible-role-grok#6 and sliced a |
|
I've tested this and it works. It does not look like we need the extra variable islandora_distro passed in as the only placed it was used has been removed. Can you pls confirm? |
|
Its used in the Vagrantfile to set up the linux user: https://github.com/Islandora-Devops/claw-playbook/blob/dev/Vagrantfile#L18 |
|
Do we need it in the README as in the following command: |
|
Yeah weird... Everything is really based off of |
|
ansible_os_family seems like a built in variable. islandora_distro is only being used here: https://github.com/Islandora-Devops/claw-playbook/blob/65a7f9ec6b4217c6b4a5ed28925eaf15ff51b931/bootstrap.yml#L17, which is being removed with this PR. |
|
@Natkeeran @dannylamb let me know what you decide about the README, and I can update if you'd like. I'm on campus today. |
|
There's also this PR that needs another set of eye. I think @jonathangreen is good with it. Not sure if that's all it needs. |
|
I'll defer to @jonathangreen on Islandora/documentation#1217. I don't have enough experience with that sort of thing to speak authoritatively about it. |
|
@Natkeeran Ok, so The only thing I want to make sure is that people can create a remote CENTOS environment without specifying that variable. @seth-shaw-unlv? Is it possible to build a remote CENTOS server without |
|
@dannylamb |
|
It seems so @dannylamb. I recently ran just the tomcat.yml against a CentOS box and it set up correctly. I only use the variable when building a vagrant box. |
|
@seth-shaw-unlv++ @Natkeeran++ Thanks guys. @ruebot Can you chop off the |
|
Islandora/documentation#1217 is merged now! |
|
@dannylamb @Natkeeran @seth-shaw-unlv that good? |
* Update to 18.04 - Update Vagrantfile to use 18.04 for Ubuntu builds - Tweak package names, and required packages for 18.04 - Updates to get rid of some deprecation warnings - Addresses Islandora/documentation#848 - Requires islandora-deprecated/ansible-role-grok#6 * Update README and remove some cruft per @Natkeeran's review. * use ansible-role-grok 2.0.0 * review * cut more
GitHub Issue: Islandora/documentation#848
What does this Pull Request do?
How should this be tested?
vagrant upInterested parties
@Islandora-Devops/committers