Clean up islandora_defaults so it's "clean" after install #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
Creating pull requests to Islandora Defaults has been described as "trivial". However, the difference between the exported feature code after a full install, and the code in the repository, is significant.
If we should be able to create PRs by exporting the feature code in a running instance, then we need to reconcile these changes that are present, even when no changes have been made.
What does this Pull Request do?
Reconciles islandora_defaults code with the results of exporting the islandora_defaults feature.
What's new?
How should this be tested?
Sorry to be snarky, but I honestly wish I knew. Technically if you were able to create an islandora without Defaults, then install this version, it should... work?
Additional Notes:
If "export from the Features page" is a desired workflow, we're going to have to do something about the submodules.
Interested parties
@dannylamb @Islandora/8-x-committers