Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up islandora_defaults so it's "clean" after install #46

Closed
wants to merge 3 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jan 26, 2021

GitHub Issue: (link)

Creating pull requests to Islandora Defaults has been described as "trivial". However, the difference between the exported feature code after a full install, and the code in the repository, is significant.

If we should be able to create PRs by exporting the feature code in a running instance, then we need to reconcile these changes that are present, even when no changes have been made.

What does this Pull Request do?

Reconciles islandora_defaults code with the results of exporting the islandora_defaults feature.

What's new?

  • file modes changed
  • UUIDs removed
  • context logic operators added
  • new sections like 'status' for taxonomy terms
  • submodules removed

How should this be tested?

Sorry to be snarky, but I honestly wish I knew. Technically if you were able to create an islandora without Defaults, then install this version, it should... work?

Additional Notes:

If "export from the Features page" is a desired workflow, we're going to have to do something about the submodules.

Interested parties

@dannylamb @Islandora/8-x-committers

@rosiel
Copy link
Member Author

rosiel commented Mar 2, 2021

I resolved the changes - thanks whoever put those in, that was nice.
As for the rest of this PR - @dannylamb , if you want to take on being the one person who has to yaml-ify every pull ever against islandora defaults, great and delete this PR.

@rosiel rosiel changed the base branch from 8.x-1.x to 2.x October 5, 2021 21:29
@rosiel rosiel closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant