ISLANDORA-2306 Delete all this module's variables. #184
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosiel It looks like this passed all the Travis CI tests, but for some reason GitHub thinks that the test is still pending. Do you know of a way we can have it run through the tests again? |
|
@bryjbrown I restarted the tests. Let's see if turning it off and turning it back on again works. |
|
@rosiel Just fired this up in a VM and tested with resetting and uninstalling using 7.x and this PM. Sure enough, 7.x didn't clean up after itself and this PR does. Works as advertised, will merge in 24 if no one has an issue. |
|
thanks @bryjbrown! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-2306
What does this Pull Request do?
Causes the "Reset" button on the admin form, and the uninstall hook, to clean up all variables.
How should this be tested?
Try to reset saved values to their defaults with the reset button in the Large Images admin form - other than the viewer, it won't work.
Same with uninstalling the module.
With this PR, they should be removed.
Additional Notes:
**These variables are named generically - possibly a hangover from 6x, but they might be used elsewhere in other modules. They don't appear to be anywhere else in the Vagrant install, though.
Interested parties
@Islandora/7-x-1-x-committers